unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: ghc-process: Replace reference to /bin/sh.
Date: Sun, 02 Oct 2016 17:03:35 +0200	[thread overview]
Message-ID: <87shse94jc.fsf@elephly.net> (raw)
In-Reply-To: <87eg3yg973.fsf@gnu.org>


Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/haskell.scm (ghc-process)[arguments]: Add phases
>> "patch-reference-to-/bin/sh" to replace reference to /bin/sh.
>
> OK!
>
> [...]
>
>> +;; Do not use this as an input.  It is part of GHC.
>>  (define-public ghc-process
>
> Should it be private then?

People may want to install this package into a profile, but we as
packagers should make sure that we don’t use it as an input.  The same
applies to the “ghc-bytestring” package (and possibly others).

Using them as inputs results in two versions to be present at compile
time, with different packages using different versions.  GHC detects
this and issues warnings about this as it can lead to all sorts of
errors.

The importer should probably avoid adding standard packages to the
inputs.

~~ Ricardo

  reply	other threads:[~2016-10-02 15:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-01 15:51 [PATCH 1/2] gnu: Do not propagate inputs in haskell.scm Ricardo Wurmus
2016-10-01 15:51 ` [PATCH 2/2] gnu: ghc-process: Replace reference to /bin/sh Ricardo Wurmus
2016-10-02 13:41   ` Ludovic Courtès
2016-10-02 15:03     ` Ricardo Wurmus [this message]
2016-10-02 13:40 ` [PATCH 1/2] gnu: Do not propagate inputs in haskell.scm Ludovic Courtès
2016-10-02 15:34   ` Ricardo Wurmus
  -- strict thread matches above, loose matches on Subject: below --
2016-10-02 15:51 [PATCH 2/2] gnu: ghc-process: Replace reference to /bin/sh Federico Beffa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shse94jc.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).