From: ludo@gnu.org (Ludovic Courtès)
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add hdf4
Date: Wed, 12 Oct 2016 14:54:40 +0200 [thread overview]
Message-ID: <87shs1ohgv.fsf@gnu.org> (raw)
In-Reply-To: <20161011.105744.1519945377775544087.post@thomasdanckaert.be> (Thomas Danckaert's message of "Tue, 11 Oct 2016 10:57:44 +0200 (CEST)")
Hello!
Thomas Danckaert <post@thomasdanckaert.be> skribis:
> this patch continues the work done by Jeremy Robst to package HDF4
>
> (https://lists.gnu.org/archive/html/guix-devel/2016-06/msg00069.html)
Nice!
> - Back then, people reported occasional build failures. I've disabled
> parallel tests and don't have any problems on my system anymore
> (maybe someone else can test?).
Will do.
> - I've added a patch to allow a shared build with Fortran interface,
> and some substitutions to remove bogus RPATH settings from the
> Makefiles (otherwise, build directories are included in the RPATH).
>
> - I've also added a variant “hdf4-alt”: by default, HDF4 includes a
> netCDF API to access HDF4 files, which clashes with the symbols in
> the real netCDF library when you try to use both libraries in your
> program. This variant uses the “--disable-netcdf” configure flag
> to avoid this. We could call it “hdf4-nonetcdf”, but the name
> “hdf4-alt” is used by Debian, so maybe it's good to use the same?
Would “hdf4-minimal” sound appropriate here? That’s a convention we use
in similar cases. Otherwise “hdf4-alt” is fine with me.
> From dd7eca9a3cfec364a05aa0f52b941f09b4dea039 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Wed, 28 Sep 2016 10:34:58 +0200
> Subject: [PATCH] gnu: Add hdf4
>
> * gnu/packages/maths.scm (hdf4, hdf4-alt): New variables.
> * gnu/packages/patches/hdf4-reproducibility.patch: New file.
> * gnu/packages/patches/hdf4-shared-fortran.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add patches.
Please credit Jeremy in a “Co-authored-by” tag.
I only have cosmetic comments:
> + (substitute*
> + (map (lambda (dir) (string-append dir "/Makefile.in"))
> + '("hdf" "hdf/examples" "hdf/fortran" "hdf/src"
> + "hdf/test" "hdf/util" "mfhdf" "mfhdf/dumper"
> + "mfhdf/examples" "mfhdf/fortran" "mfhdf/hdfimport"
> + "mfhdf/hdiff" "mfhdf/hrepack" "mfhdf/libsrc"
> + "mfhdf/ncgen" "mfhdf/ncdump" "mfhdf/nctest"
> + "mfhdf/test" "mfhdf/xdr"))
Maybe simply (find-files "." "^Makefile\\.in$")?
> --- /dev/null
> +++ b/gnu/packages/patches/hdf4-reproducibility.patch
> @@ -0,0 +1,47 @@
> +Remove/patch unreproducible config data.
> +---
> + configure | 9 ++++++++-
> + libhdf4.settings.in | 6 +++---
> + 2 files changed, 11 insertions(+), 4 deletions(-)
> +
> +diff --git a/configure b/configure
> +index eb9f346..ebab94d 100755
> +--- a/configure
> ++++ b/configure
> +@@ -23163,7 +23163,14 @@ H4_VERSION="`cut -d' ' -f3 $srcdir/README.txt | head -1`"
> +
> +
> + ## Configuration date
> +- CONFIG_DATE="`date`"
> ++CONFIG_DATE="`date -u`"
> ++if test -n "$SOURCE_DATE_EPOCH"; then
> ++ CONFIG_DATE=`date -u -d "@$SOURCE_DATE_EPOCH" 2>/dev/null \
> ++ || date -u -r "$SOURCE_DATE_EPOCH" 2>/dev/null`
> ++ if test -z "$CONFIG_DATE"; then
> ++ as_fn_error $? "malformed SOURCE_DATE_EPOCH" "$LINENO" 5
> ++ fi
> ++fi
It’d be enough to just do:
- CONFIG_DATE="`date`"
+ CONFIG_DATE="$SOURCE_DATE_EPOCH"
The smaller the patch, the better. :-)
Otherwise LGTM. Could you send an updated patch?
Thank you!
Ludo’.
next prev parent reply other threads:[~2016-10-12 12:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 8:57 [PATCH] gnu: Add hdf4 Thomas Danckaert
2016-10-12 12:54 ` Ludovic Courtès [this message]
2016-10-12 18:50 ` Thomas Danckaert
2016-10-12 20:28 ` Ludovic Courtès
2016-10-14 8:11 ` Andreas Enge
2016-10-14 11:13 ` Thomas Danckaert
[not found] ` <20161014.110029.603260973900204345.post@thomasdanckaert.be>
2016-10-16 15:05 ` Andreas Enge
-- strict thread matches above, loose matches on Subject: below --
2016-05-23 17:22 Jeremy Robst
2016-05-23 18:17 ` Leo Famulari
2016-05-24 13:20 ` Jeremy Robst
2016-05-24 19:06 ` Eric Bavier
2016-05-25 17:42 ` Jeremy Robst
2016-05-27 17:19 ` Leo Famulari
2016-05-28 14:32 ` Ludovic Courtès
2016-05-29 17:36 ` Jeremy Robst
2016-05-29 22:07 ` Ludovic Courtès
2016-06-02 14:43 ` Eric Bavier
2016-06-02 14:58 ` Jeremy Robst
2016-06-03 8:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shs1ohgv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=post@thomasdanckaert.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).