From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 2/2] gnu: Add emacs-org-trello.
Date: Thu, 27 Oct 2016 16:09:32 +0200
Message-ID: <87shrhg9yb.fsf@elephly.net>
References: <87oa2887b1.fsf@gnu.org> <87bmy8glwz.fsf@elephly.net>
	<877f8udwha.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bzlNN-0006P4-NL
	for guix-devel@gnu.org; Thu, 27 Oct 2016 10:09:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bzlNJ-0001ZV-IH
	for guix-devel@gnu.org; Thu, 27 Oct 2016 10:09:49 -0400
In-reply-to: <877f8udwha.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Roel Janssen <roel@gnu.org>, Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org


Roel Janssen <roel@gnu.org> writes:

>> The cask file says:
>>
>> (development
>>  (depends-on "dash-functional")
>>  (depends-on "dash")
>
> @code{dash} provides @code{dash-functional}.
>
>>  (depends-on "undercover")
>
> This one is needed to run the tests.
>
>>  (depends-on "ert-runner")
>>  (depends-on "ert")
>>  (depends-on "ert-expectations")
>
> These should be built-in.  See:
> https://www.gnu.org/software/emacs/manual/html_node/ert/
>
> (Or M-x ert)
>
>>  (depends-on "el-mock")
>>  (depends-on "helm"))
>
> These should be added too, to run the tests.
>
> I added undercover, el-mock and helm to the inputs.

[…]

> +(define-public emacs-org-trello
> +  (package
> +    (name "emacs-org-trello")
> +    (version "0.7.9")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/org-trello/org-trello/archive/"
> +                    version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "074dka8g673bj1ck5vavbjaij5jyniygdlw51mdds005wd2br9wf"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-deferred" ,emacs-deferred)
> +       ("emacs-request" ,emacs-request)
> +       ("emacs-dash" ,emacs-dash)
> +       ("emacs-s" ,emacs-s)
> +       ("emacs-undercover" ,emacs-undercover)
> +       ("emacs-el-mock" ,emacs-el-mock)
> +       ("emacs-helm" ,emacs-helm)))

Hmm, now I wonder… I just looked at emacs.scm and only one package there
has “emacs-undercover” as an input (and it looks like this was a
mistake).  We seem not to add test inputs to Emacs packages.

@Alex: could you please confirm this?  Should these inputs be mentioned
at all?  If so, is it sufficient to add them to native-inputs?

~~ Ricardo