From: Ricardo Wurmus <rekado@elephly.net>
To: Roel Janssen <roel@gnu.org>, Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add emacs-org-trello.
Date: Thu, 27 Oct 2016 16:09:32 +0200 [thread overview]
Message-ID: <87shrhg9yb.fsf@elephly.net> (raw)
In-Reply-To: <877f8udwha.fsf@gnu.org>
Roel Janssen <roel@gnu.org> writes:
>> The cask file says:
>>
>> (development
>> (depends-on "dash-functional")
>> (depends-on "dash")
>
> @code{dash} provides @code{dash-functional}.
>
>> (depends-on "undercover")
>
> This one is needed to run the tests.
>
>> (depends-on "ert-runner")
>> (depends-on "ert")
>> (depends-on "ert-expectations")
>
> These should be built-in. See:
> https://www.gnu.org/software/emacs/manual/html_node/ert/
>
> (Or M-x ert)
>
>> (depends-on "el-mock")
>> (depends-on "helm"))
>
> These should be added too, to run the tests.
>
> I added undercover, el-mock and helm to the inputs.
[…]
> +(define-public emacs-org-trello
> + (package
> + (name "emacs-org-trello")
> + (version "0.7.9")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/org-trello/org-trello/archive/"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "074dka8g673bj1ck5vavbjaij5jyniygdlw51mdds005wd2br9wf"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-deferred" ,emacs-deferred)
> + ("emacs-request" ,emacs-request)
> + ("emacs-dash" ,emacs-dash)
> + ("emacs-s" ,emacs-s)
> + ("emacs-undercover" ,emacs-undercover)
> + ("emacs-el-mock" ,emacs-el-mock)
> + ("emacs-helm" ,emacs-helm)))
Hmm, now I wonder… I just looked at emacs.scm and only one package there
has “emacs-undercover” as an input (and it looks like this was a
mistake). We seem not to add test inputs to Emacs packages.
@Alex: could you please confirm this? Should these inputs be mentioned
at all? If so, is it sufficient to add them to native-inputs?
~~ Ricardo
next prev parent reply other threads:[~2016-10-27 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 21:09 [PATCH 2/2] gnu: Add emacs-org-trello Roel Janssen
2016-10-25 21:26 ` Ricardo Wurmus
2016-10-27 8:31 ` Roel Janssen
2016-10-27 14:09 ` Ricardo Wurmus [this message]
2016-10-27 18:22 ` Alex Kost
2016-10-27 18:48 ` Ricardo Wurmus
2016-10-28 9:30 ` Alex Kost
2016-10-28 13:03 ` Roel Janssen
2016-10-28 16:35 ` Ricardo Wurmus
2016-10-28 17:52 ` Roel Janssen
2016-10-28 16:21 ` Federico Beffa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shrhg9yb.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).