From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add qtwebkit.
Date: Mon, 07 Nov 2016 10:17:57 +0100
Message-ID: <87shr3wsvu.fsf@gnu.org>
References: <20161030002214.GA18050@jasmine>
	<20161102.140509.1673098785705461056.post@thomasdanckaert.be>
	<20161105184538.GB11070@jasmine>
	<20161105.212454.307496631396320122.post@thomasdanckaert.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41253)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c3g44-00066H-Hj
	for guix-devel@gnu.org; Mon, 07 Nov 2016 04:18:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c3g41-0003Cm-Di
	for guix-devel@gnu.org; Mon, 07 Nov 2016 04:18:04 -0500
In-Reply-To: <20161105.212454.307496631396320122.post@thomasdanckaert.be>
	(Thomas Danckaert's message of "Sat, 05 Nov 2016 21:24:54 +0100
	(CET)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: guix-devel@gnu.org

Hi,

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> From: Leo Famulari <leo@famulari.name>
> Subject: Re: [PATCH] gnu: Add qtwebkit.
> Date: Sat, 5 Nov 2016 14:45:38 -0400
>
>> Can you add a code comment mentioning that this package is not
>> officially supported by the Qt project?
>
> done!

I agree with Leo that it=E2=80=99s okay to provide QtWebKit.

I went ahead and pushed these two patches:

> From 68a4c4accb53cb11c70d242d78e14259e788ac86 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Sat, 5 Nov 2016 21:18:13 +0100
> Subject: [PATCH 2/2] gnu: texmaker: Use modular qt and qtwebkit.
>
> * gnu/packages/tex.scm (texmaker)[inputs]: Use modular qt and qtwebkit.

[...]

> From 0348e13d0aaae4034e8a76f47512e64432b1f84f Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Wed, 26 Oct 2016 11:11:01 +0200
> Subject: [PATCH 1/2] gnu: Add qtwebkit.
>
> * gnu/packages/qt.scm (qtwebkit): New variable.

[...]

> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "http://download.qt.io/community_releases/"
> +                            (version-major+minor version)
> +                            "/" version "/qtwebkit-opensource-src-" vers=
ion
> +                            ".tar.xz"))
> +        ;; note: since Qt 5.6, Qt no longer officially supports qtwebkit

I added a link to the message that Leo mentioned here.

Thanks!

Ludo=E2=80=99.