From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH] gnu: psyclpc: Downgrade to 27f21a3bf0d140f0d2680c695e8df229b46a814b. Date: Sat, 03 Dec 2016 18:22:03 +0000 Message-ID: <87shq450vo.fsf@we.make.ritual.n0.is> References: <20161201191312.11951-1-ng0@libertad.pw> <20161201191312.11951-2-ng0@libertad.pw> <87zikdaqby.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDEx0-0000hf-1F for guix-devel@gnu.org; Sat, 03 Dec 2016 13:22:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDEww-0004g7-Rh for guix-devel@gnu.org; Sat, 03 Dec 2016 13:22:18 -0500 Received: from aibo.runbox.com ([91.220.196.211]:39307) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cDEww-0004eg-GB for guix-devel@gnu.org; Sat, 03 Dec 2016 13:22:14 -0500 Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1cDEwt-0005Yw-CL for guix-devel@gnu.org; Sat, 03 Dec 2016 19:22:11 +0100 Received: from tor-exit4-readme.dfri.se ([171.25.193.78] helo=localhost) by mailfront11.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1cDEwo-0004SA-KL for guix-devel@gnu.org; Sat, 03 Dec 2016 19:22:06 +0100 In-Reply-To: <87zikdaqby.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Okay, correction: please do not apply this downgrade. The reasons for this are as follows (tl;dr: fix will be in psyced, which is currently not in master and psyclpc is behaving as it should): ng0 I don't want the software in master which is known to have a problem, but I added the commit before I was remember that this problem exists (lack of issue tracker for this application, i have addressed it and hope it gets added soon to our issue tracker), so it builds, yeah, but it has problems. the only known problem exists in combination with psyced, which depends on psyclpc at runtime. if you were to use ng0 this version you'd have no xmpp functionality. it is possible that there are no other problems at all. I've pointed out that we (upstream) need to write tests for both applications which can prevent relying just on "you know the code". ng0 so if you think it's okay to keep the package as it is, i'm okay with it ng0 from upstream perspective I found the software broken and want to revert until it (the way pcre is used) is fixed. ng0 eh downgrade ng0 sorry, terms … ng0 the fix for this problem will be in psyced, not psyclpc ng0 so theoretically psyclpc is good … ng0 ok. I thought about it.. there's no harm in keeping that psyclpc version. and I'll ask for a new release to be made as soon as psyced is fixed. i think the preference was to release both together ng0 i'll put a summary of what I've written as an reply to the thread so it doesn't get applied ng0 writes: > The correct spelling of: > gnu: psyclpc: Downgrade to 27f21a3bf0d140f0d2680c695e8df229b46a814b. > > would be: > gnu: psyclpc: Downgrade to 20160821-3.27f21a3. > > Can the person who applies this patch change it? > Thanks! > > ng0 writes: > >> * gnu/packages/messaging.scm (psyclpc): Downgrade it. >> >> The bundled pcre and reproducible build is introduced in an commit >> which broke xmpp functionality with psyclpc in psyced, therefore we >> wait for an fix upstream in psyced and then update psyclpc again >> when psyced is added. >> --- >> gnu/packages/messaging.scm | 14 ++++++++------ >> 1 file changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm >> index 8660915bb..2b80589f0 100644 >> --- a/gnu/packages/messaging.scm >> +++ b/gnu/packages/messaging.scm >> @@ -980,10 +980,13 @@ including psyced.") >> (synopsis "PSYC library in C") >> (license license:agpl3+))) >> >> -;; This commit removes the historic bundled pcre and makes psyclpc reproducible. >> +;; The bundled pcre and reproducible build is introduced in an commit >> +;; which broke xmpp functionality with psyclpc in psyced, therefore we >> +;; wait for an upstream fix in psyced and then update psyclpc again >> +;; when psyced is added. >> (define-public psyclpc >> - (let* ((commit "61cf9aa81297085e5c40170fd01221c752f8deba") >> - (revision "2")) >> + (let* ((commit "27f21a3bf0d140f0d2680c695e8df229b46a814b") >> + (revision "3")) >> (package >> (name "psyclpc") >> (version (string-append "20160821-" revision "." (string-take commit 7))) >> @@ -995,7 +998,7 @@ including psyced.") >> (file-name (string-append name "-" version "-checkout")) >> (sha256 >> (base32 >> - "1viwqymbhn3cwvx0zl58rlzl5gw47zxn0ldg2nbi55ghm5zxl1z5")))) >> + "1m17xyixbh6wfwk727h3cfjmyfplcgvwbgh12kap1856xiqh99c5")))) >> (build-system gnu-build-system) >> (arguments >> `(#:tests? #f ; There are no tests/checks. >> @@ -1034,8 +1037,7 @@ including psyced.") >> #:make-flags (list "install-all"))) >> (inputs >> `(("zlib" ,zlib) >> - ("openssl" ,openssl) >> - ("pcre" ,pcre))) >> + ("openssl" ,openssl))) >> (native-inputs >> `(("pkg-config" ,pkg-config) >> ("bison" ,bison) >> -- >> 2.11.0 >> >> > > -- > ♥Ⓐ ng0 | ng0.chaosnet.org > > -- ♥Ⓐ ng0 | ng0.chaosnet.org