From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/3] gnu: Add fluid. Date: Mon, 09 Jan 2017 10:32:52 +0100 Message-ID: <87shospohn.fsf@gnu.org> References: <20170104124703.9621-1-ng0@libertad.pw> <20170104145305.13901-1-ng0@libertad.pw> <20170104145305.13901-3-ng0@libertad.pw> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQWK3-0000is-LY for guix-devel@gnu.org; Mon, 09 Jan 2017 04:33:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQWJz-0000BR-E4 for guix-devel@gnu.org; Mon, 09 Jan 2017 04:32:59 -0500 In-Reply-To: <20170104145305.13901-3-ng0@libertad.pw> (ng0@libertad.pw's message of "Wed, 4 Jan 2017 14:53:04 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org Hi! ng0 skribis: > * gnu/packages/qt.scm (fluid): New variable. I think it=E2=80=99s best to put it in kde.scm or some other place; it feels wrong to import (gnu packages kde-frameworks) in (gnu packages qt). > +(define-public fluid > + (package > + (name "fluid") > + (version "0.9.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/lirios/fluid/releases/dow= nload/" > + "v" version "/" name "-" version ".tar.xz")) > + (file-name (string-append name "-" version ".tar.xz")) > + (sha256 > + (base32 > + "0m6mijlnizgvmh0z2wcrmkfl5cdrylxz3d7bqii8dasmm0q8f68y")))) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f ; XXX: The tests do not find the fluid module. > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'setenv > + (lambda _ > + (setenv "QT_QPA_PLATFORM" "offscreen")))))) Please add as a comment why this is needed, and add this phase before =E2=80=98check=E2=80=99 for clarity. Also add #t as the return value. I removed the #:tests? #f as Danny suggested, but the tests are failing in a way that suggests there=E2=80=99s something wrong: --8<---------------cut here---------------start------------->8--- Test project /tmp/guix-build-fluid-0.9.0.drv-0/build Start 1: tst_controls 1/3 Test #1: tst_controls .....................***Failed 0.05 sec file:///tmp/guix-build-fluid-0.9.0.drv-0/fluid-0.9.0/tests/auto/controls/ts= t_icon.qml:17:1: module "Fluid.Controls" is not installed=20 import Fluid.Controls 1.0=20 ^ ********* Start testing of tst_controls ********* Config: Using QtTest library 5.7.1, Qt 5.7.1 (x86_64-little_endian-lp64 sha= red (dynamic) release build; by GCC 4.9.4) QWARN : tst_controls::tst_icon::compile()=20 /tmp/guix-build-fluid-0.9.0.drv-0/fluid-0.9.0/tests/auto/controls/tst_ico= n.qml produced 1 error(s): /tmp/guix-build-fluid-0.9.0.drv-0/fluid-0.9.0/tests/auto/controls/tst_i= con.qml:17,1: module "Fluid.Controls" is not installed Working directory: /tmp/guix-build-fluid-0.9.0.drv-0/build/tests/auto/con= trols View: QQuickView, import paths: '/tmp/guix-build-fluid-0.9.0.drv-0/build/tests/auto/controls' 'qrc:/qt-project.org/imports' '/gnu/store/0v50sh1lgkwkhxxq1v37ayxr15vayn6k-qtdeclarative-5.7.1/qml' '/gnu/store/31mn2qgx5gh3zg3pk4w0j2a89jrkqnyv-qtquickcontrols2-5.7.1/qml' Plugin paths: '.' FAIL! : tst_controls::tst_icon::compile() module "Fluid.Controls" is not i= nstalled --8<---------------cut here---------------end--------------->8--- Could you check what=E2=80=99s going on? Thanks you! Ludo=E2=80=99.