From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add guildhall.
Date: Mon, 16 Jan 2017 10:55:05 +0100
Message-ID: <87shojz5vq.fsf@gnu.org>
References: <20170115210219.13148-1-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56244)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cT40N-0004Qr-8l
	for guix-devel@gnu.org; Mon, 16 Jan 2017 04:55:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cT40J-0002Mp-QR
	for guix-devel@gnu.org; Mon, 16 Jan 2017 04:55:11 -0500
In-Reply-To: <20170115210219.13148-1-rekado@elephly.net> (Ricardo Wurmus's
	message of "Sun, 15 Jan 2017 22:02:19 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/guile.scm (guildhall): New variable.

[...]

> +       `(;; FIXME: tests fail for unknown reason.  They seem to try to l=
oad
> +         ;; the bash executable as a Scheme file.  See bug report at
> +         ;; https://github.com/ijp/guildhall/issues/22
> +         #:tests? #f

I think that=E2=80=99s because Makefile.am has:

  TESTS_ENVIRONMENT =3D $(GUILE) =E2=80=A6

whereas it should instead do (assuming test files have the .scm
extension):

  SCM_LOG_DRIVER =3D $(GUILE) =E2=80=A6

and have =E2=80=98TESTS_ENVIRONMENT=E2=80=99 contain only environment varia=
bles.

See
<http://git.savannah.gnu.org/cgit/skribilo.git/commit/?id=3Dd3a740cca088e6e=
c981e4b80a10f53fcfe094511>
for an example of the modification that is needed.

Also, maybe add a =E2=80=98package-for-guile-2.2=E2=80=99 variant if that w=
orks (which
seems unlikely=E2=80=A6).

Thanks!

Ludo=E2=80=99.