From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH 06/11] gnu: Add lxde-common. Date: Mon, 23 Jan 2017 23:21:28 +0000 Message-ID: <87sho9nz0n.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> References: <20170123185559.15596-1-contact.ng0@cryptolab.net> <20170123185559.15596-7-contact.ng0@cryptolab.net> <878tq15swe.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVnvd-0001gT-4t for guix-devel@gnu.org; Mon, 23 Jan 2017 18:21:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVnva-000396-0y for guix-devel@gnu.org; Mon, 23 Jan 2017 18:21:37 -0500 Received: from latitanza.investici.org ([82.94.249.234]:43942) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cVnvZ-00038a-R9 for guix-devel@gnu.org; Mon, 23 Jan 2017 18:21:33 -0500 In-Reply-To: <878tq15swe.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Marius Bakke writes: > contact.ng0@cryptolab.net writes: > >> From: ng0 >> >> * gnu/packages/lxde.scm (lxde-common): New variable. > > This application ships a "lxde-screenlock.desktop" file referring to > "lxlock". It would be nice to have that packaged too and substitute wit= h > the full path. You mean this lxlock? https://github.com/lxde/lxsession/blob/master/lxlock/lxlock I can patch in the absolute path, but I hardly think that's necessary :) > Going through the series now. I think "lxde-icon-theme" and > "lxmenu-data" might as well be native-inputs since they only contain > images and similar. I have this in my local branch. Okay. > Cool to get LXDE in Guix, thanks for working on this! :) Thanks for your review. --=20 =E2=99=A5=E2=92=B6 ng0 -- https://www.inventati.org/patternsinthechaos/