From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] services: Fix 'mkdir-p' in activation scripts.
Date: Tue, 24 Jan 2017 22:21:07 +0100
Message-ID: <87sho85f3w.fsf@gnu.org>
References: <87pojdx4jy.fsf@gnu.org>
	<20170124002419.20893-1-clement@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51698)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cW8Wf-00029G-Jx
	for guix-devel@gnu.org; Tue, 24 Jan 2017 16:21:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cW8Wc-0001bC-Fk
	for guix-devel@gnu.org; Tue, 24 Jan 2017 16:21:13 -0500
In-Reply-To: <20170124002419.20893-1-clement@lassieur.org> (=?utf-8?Q?=22C?=
	=?utf-8?Q?l=C3=A9ment?=
	Lassieur"'s message of "Tue, 24 Jan 2017 01:24:19 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: guix-devel@gnu.org

Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:

> * gnu/services/cuirass.scm (cuirass-activation): Import (guix build utils=
) and
>   remove (with-imported-modules '((guix build utils))).
> * gnu/services/cups.scm (%cups-activation): Idem.
> * gnu/services/networking.scm (ntp-service-activation): Idem.
>
> * gnu/services/mail.scm (opensmtpd-activation): Import (guix build utils).
> * gnu/services/spice.scm (spice-vdagent-activation): Idem.
> * gnu/services/ssh.scm (openssh-activation): Idem.
>   (dropbear-activation): Idem.
> * gnu/services/vpn.scm (%openvpn-activation): Idem.

Good catch!

>          (db    (dirname (cuirass-configuration-database config)))
>          (user  (cuirass-configuration-user config))
>          (group (cuirass-configuration-group config)))
> -    (with-imported-modules '((guix build utils))
> -      #~(begin
> -          (use-modules (guix build utils))
> +    #~(begin
> +        (use-modules (guix build utils))
> +        (mkdir-p #$cache)
> +        (mkdir-p #$db)

The =E2=80=98with-imported-modules=E2=80=99 form should be preserved: it en=
sures that
(guix build utils) is present in the build and/or execution environment.

It=E2=80=99s the other places, those that lack it, that should be fixed.  T=
hat
should go into a different patch though, and there=E2=80=99s no rush since =
those
gexps are actually used in a context where (guix build utils) happens to
be available anyway.

>  (define %cups-activation
>    ;; Activation gexp.
> -  (with-imported-modules '((guix build utils))
> -    #~(begin

Same here.

Apart from that the patch LGTM.  Could you send an updated version just
without these two things?

Thank you!

Ludo=E2=80=99.