From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Subject: Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners
	path types.
Date: Mon, 27 Feb 2017 10:39:27 +0100
Message-ID: <87shn0ug4w.fsf@lassieur.org>
References: <20170226194203.25746-1-clement@lassieur.org>
	<cucr32kuhn7.fsf@igalia.com> <87tw7gugze.fsf@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1ciHmJ-0000YD-5b
	for guix-devel@gnu.org; Mon, 27 Feb 2017 04:39:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1ciHmF-0000q9-7w
	for guix-devel@gnu.org; Mon, 27 Feb 2017 04:39:35 -0500
Received: from mail.lassieur.org ([83.152.10.219]:35758)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <clement@lassieur.org>)
	id 1ciHmF-0000ol-0U
	for guix-devel@gnu.org; Mon, 27 Feb 2017 04:39:31 -0500
In-reply-to: <87tw7gugze.fsf@lassieur.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Andy Wingo <wingo@igalia.com>
Cc: guix-devel@gnu.org

Cl=C3=A9ment Lassieur <clement@lassieur.org> writes:

> Andy Wingo <wingo@igalia.com> writes:
>
>> On Sun 26 Feb 2017 20:42, Cl=C3=A9ment Lassieur <clement@lassieur.org>=
 writes:
>>
>>> * gnu/services/mail.scm (unix-listener-configuration)[path]
>>>   (fifo-listener-configuration)[path]: Change type from 'file-name' t=
o 'string'.
>>> * doc/guix.texi (Mail Services): Document it.
>>
>> Why's that?  Is the extra checking from the file-name type (that the
>> string start with "/") getting in the way of something?
>
> Yes, because the path is also used as the section name (see
> http://wiki2.dovecot.org/Services#Service_listeners).
>
> So for example, this code (from gnu/services/mail.scm:445) raises an
> error because "lmtp" doesn't start with "/":
>
> (service-configuration
>  (kind "lmtp")
>  (listeners
>   (list (unix-listener-configuration (path "lmtp") (mode "0666")))))
>
> I don't understand how it could work before.  Maybe the check wasn't
> done.

Well, maybe here "lmtp" is not the section name, but the path, relative
to "base_dir".  Sould I update the documentation to specify that "path"
may be relative to "base_dir" too?

But anyway there's still the bug, because relative paths don't start
with "/".