From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/2] doc: Symlink daemon start-up files. Date: Mon, 06 Mar 2017 11:23:27 +0100 Message-ID: <87shmqvh40.fsf@gnu.org> References: <1479466834-3508-1-git-send-email-h.goebel@crazy-compilers.com> <1479466834-3508-2-git-send-email-h.goebel@crazy-compilers.com> <20161118203124.GA27280@jasmine> <20170115182310.GA26341@jasmine> <8737gj1gib.fsf@gnu.org> <20170305205553.GB2279@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckpnh-0000ne-Pc for guix-devel@gnu.org; Mon, 06 Mar 2017 05:23:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckpnd-0005Yj-Vy for guix-devel@gnu.org; Mon, 06 Mar 2017 05:23:33 -0500 In-Reply-To: <20170305205553.GB2279@jasmine> (Leo Famulari's message of "Sun, 5 Mar 2017 15:55:53 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > On Mon, Jan 16, 2017 at 10:49:32AM +0100, Ludovic Court=C3=A8s wrote: >> > On Fri, Nov 18, 2016 at 03:31:24PM -0500, Leo Famulari wrote: >> > I think we should go back to the "old way" of instructing users to copy >> > the file... >> > >> >> I'd argue it should point to /var/guix/profiles/per-user/root/... >> > >> > ... and make the service file execute this path. >>=20 >> Could you send a patch? > > I've attached two patches. The first updates the instructions in the > manual, and the second builds the service files with the '/var/guix...' > path. > > From 62249ac64fb5cd0235bba28197cb7ac697719b83 Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Sun, 5 Mar 2017 14:04:34 -0500 > Subject: [PATCH 1/2] Revert "doc: Symlink daemon start-up files." > > This reverts commit b7230de54b493da5a78922b4226255763b525a98. > > Versions of systemd that supported symlinked service files are not yet wi= dely > deployed. > > See this thread for more information: > http://lists.gnu.org/archive/html/guix-devel/2017-01/msg01199.html Could you add this reference in a @c comment in the .texi file? Otherwise LGTM! > From b79385c076ba4921fdf5f3ad2af76d3d171515c8 Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Sun, 5 Mar 2017 14:33:13 -0500 > Subject: [PATCH 2/2] build: Don't embed absolute paths in .service and .c= onf > service files. > > Otherwise, users will be stuck running an old copy of guix and the guix-d= aemon > if they copy the service files instead of symlinking them. > > * etc/guix-daemon.conf.in, etc/guix-daemon.service.in, etc/guix-publish.c= onf.in, > etc/guix-publish.service.in: Expand @localstatedir@ instead of @bindir@. > * nix/local.mk (etc/guix-%.service, etc/guix-%.conf): Use @localstatedir@ > instead of @bindir@. OK. Thanks for addressing this! Ludo=E2=80=99.