From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: GRUB EFI installation breakage Date: Tue, 22 Aug 2017 22:00:50 +0200 Message-ID: <87shgj2wzx.fsf@fastmail.com> References: <87efs34tfl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkFMA-0003fQ-Lr for guix-devel@gnu.org; Tue, 22 Aug 2017 16:00:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkFM5-0006SR-Nx for guix-devel@gnu.org; Tue, 22 Aug 2017 16:00:58 -0400 In-Reply-To: <87efs34tfl.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Andy Wingo Cc: guix-devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello, > > To reconfigure my system on UEFI, I had to apply this patch: > > modified gnu/bootloader/grub.scm > @@ -401,7 +401,8 @@ submenu \"GNU system, old configurations...\" {~%") > ;; root partition. > (setenv "GRUB_ENABLE_CRYPTODISK" "y") > (unless (zero? (system* grub-install "--boot-directory" install-= dir > - "--efi-directory" efi-dir)) > + ;; "--efi-directory" efi-dir > + )) > (error "failed to install GRUB (EFI)"))))) >=20=20 > > Before that =E2=80=98grub-install=E2=80=99 would fail because =E2=80=98ef= i-dir=E2=80=99 would actually > be =E2=80=9C/dev/sda=E2=80=9D, which is what I have in the =E2=80=98devic= e=E2=80=99 field of > =E2=80=98grub-configuration=E2=80=99. > > Removing the =E2=80=9C--efi-directory=E2=80=9D solves the problem because= =E2=80=98grub-install=E2=80=99 > automatically determines that the EFI directory is mounted at /boot/efi. > > I think 2941b347b664a3d3114de0ac95e28db78db66144 is bogus because it > assumes that the second argument of the gexp=E2=80=99d lambda is =E2=80= =98efi-dir=E2=80=99, > where in fact it is the =E2=80=98device=E2=80=99 field of the bootloader = config. > > So what is the preferred fix? Simply remove =E2=80=9C--efi-directory=E2= =80=9D like I > did above, and rename =E2=80=98efi-dir=E2=80=99 to =E2=80=98device=E2=80= =99 to avoid the ambiguity? > Thoughts? Maybe we could rename "device" to something like "target" and update the documentation to mention that "target" means the _mounted_ EFI System Partition for grub-efi, but is typically a block device. "device" was a no-op for grub-efi anyway since it autodiscovered "/boot/efi", at least now we can choose a different location. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmcjXMACgkQoqBt8qM6 VPo18wf5AV5NmZdrrFqdf/G5h3ozWEGZgKtnu0xBPbZsPGfqzc8V7EOhXx+d3WaP VB6hirUniCi2K8mwQ/myL6nVQAAxKrNkUGFC3cFyB99ZAELoF+m9vMhYDQ9YhS9Y RwLXcGl2SmM7HQaK4QI+63WAP5D+8HzzWOVONdlvZUX+7WuoHJ7uvP4nxOvn3Yef 4lG79WalmSq/FYYxczWS2wmhIZf2sn/532w9Y1AN9PTG1fBVydsu7J3wFDzQ5fee Jzg0GfRvewxjHZ2QOaSLp1/QuDd8q9WBiQxB0IduVq64gjQvh2ywsDahF2N0zXF3 FLoqN78i1GBqztF6ETSvs4SurBQGfw== =IgjK -----END PGP SIGNATURE----- --=-=-=--