From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: IcedTea is not linking correctly with libjvm.so Date: Tue, 24 Oct 2017 15:17:28 +0200 Message-ID: <87she8d6s7.fsf@elephly.net> References: <87y3o56kve.fsf@gnu.org> <877evokzir.fsf@gmail.com> <87mv4jqirt.fsf@gnu.org> <87fuaa536t.fsf@gmail.com> <87bmkwu61j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7SuV-0005ZL-FB for guix-devel@gnu.org; Wed, 25 Oct 2017 17:08:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7SuT-0004q7-0e for guix-devel@gnu.org; Wed, 25 Oct 2017 17:08:23 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e7SuS-0004pd-P9 for guix-devel@gnu.org; Wed, 25 Oct 2017 17:08:20 -0400 In-reply-to: <87bmkwu61j.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel Roel Janssen writes: > gnu/packages/java.scm | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index 95fba20e8..81cfdc132 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -1404,6 +1404,18 @@ bootstrapping purposes.") > (copy-recursively "openjdk.build/j2re-image" jre) > (copy-recursively "openjdk.build/j2sdk-image" jdk)) > #t)) > + ;; Some of the libraries in the lib/amd64 folder link to libjvm.so. But that > + ;; shared object is located in the server/ folder, so it cannot be found. > + ;; This phase creates a symbolic link in the lib/amd64 folder so that the > + ;; other libraries can find it. > + ;; > + ;; See https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00169.html > + (add-after 'install 'install-libjvm > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((lib-path (string-append (assoc-ref outputs "out") "/lib/amd64"))) > + (system* "ln" "--symbolic" > + (string-append lib-path "/server/libjvm.so") > + (string-append lib-path "/libjvm.so"))))) Please use (symlink foo bar) instead of calling the “ln” tool. Also end the phase with #t. Other than that I think it’s fine as a workaround. Please also add a FIXME to the comment, so that we can revisit this later. Thanks! -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net