From: Roel Janssen <roel@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: IcedTea is not linking correctly with libjvm.so
Date: Mon, 30 Oct 2017 11:22:02 +0100 [thread overview]
Message-ID: <87she1j5px.fsf@gnu.org> (raw)
In-Reply-To: <87she8d6s7.fsf@elephly.net>
Ricardo Wurmus writes:
> Roel Janssen <roel@gnu.org> writes:
>
>> gnu/packages/java.scm | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
>> index 95fba20e8..81cfdc132 100644
>> --- a/gnu/packages/java.scm
>> +++ b/gnu/packages/java.scm
>> @@ -1404,6 +1404,18 @@ bootstrapping purposes.")
>> (copy-recursively "openjdk.build/j2re-image" jre)
>> (copy-recursively "openjdk.build/j2sdk-image" jdk))
>> #t))
>> + ;; Some of the libraries in the lib/amd64 folder link to libjvm.so. But that
>> + ;; shared object is located in the server/ folder, so it cannot be found.
>> + ;; This phase creates a symbolic link in the lib/amd64 folder so that the
>> + ;; other libraries can find it.
>> + ;;
>> + ;; See https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00169.html
>> + (add-after 'install 'install-libjvm
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let* ((lib-path (string-append (assoc-ref outputs "out") "/lib/amd64")))
>> + (system* "ln" "--symbolic"
>> + (string-append lib-path "/server/libjvm.so")
>> + (string-append lib-path "/libjvm.so")))))
>
> Please use (symlink foo bar) instead of calling the “ln” tool. Also end
> the phase with #t.
>
> Other than that I think it’s fine as a workaround. Please also add a
> FIXME to the comment, so that we can revisit this later.
>
> Thanks!
I used (symlink ...), added a FIXME, rebuilt to see if it worked, and
pushed in 491dc2fb1.
Thanks!
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2017-10-30 10:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 7:05 IcedTea is not linking correctly with libjvm.so Roel Janssen
2017-10-21 9:16 ` Ludovic Courtès
2017-10-24 13:11 ` Roel Janssen
2017-10-21 20:38 ` Chris Marusich
2017-10-22 15:55 ` Roel Janssen
2017-10-22 20:37 ` Chris Marusich
2017-10-24 11:46 ` Roel Janssen
2017-10-24 13:17 ` Ricardo Wurmus
2017-10-30 10:22 ` Roel Janssen [this message]
2017-10-30 16:35 ` Ricardo Wurmus
2017-11-01 9:17 ` Roel Janssen
2017-11-01 16:03 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87she1j5px.fsf@gnu.org \
--to=roel@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).