unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Web interface pushed
@ 2018-07-29 22:08 Clément Lassieur
  2018-07-29 23:46 ` Ludovic Courtès
  2018-07-30  7:38 ` amirouche
  0 siblings, 2 replies; 32+ messages in thread
From: Clément Lassieur @ 2018-07-29 22:08 UTC (permalink / raw)
  To: Tatiana Sholokhova; +Cc: Guix-devel

Hi Tatiana,

So, I did the pagination review and I pushed your work tonight.  :-)

I added checks to avoid crashes when the table is empty (FIRST and LAST
expect non-empty lists).

I modified a few minor things too:

- the commit message, so that it matches our convention
- the indentation
- I removed code comments, trailing '\' in SQL queries, useless
  newlines, useless exports
- I renamed a few things (e.g. thing-list with things, %pagesize with
  %page-size)
- I replaced (+ 1 x) with (1+ x)
- I used string-join to avoid long strings
- I used FIRST instead of CAR when used with LAST (for more consistency,
  but it's the exact same thing)
- I replaced FIRST and LAST with BUILD-ID and BUILD-STOPTIME, so to make
  it more furure-proof and easier to understand
- I used a format string for RESPOND-HTML (to avoid "\"\"")
- I finally opted for a non-parameter %page-size (yes, I changed my mind
  :-), I just didn't see any reason to use one)
- I removed ('page (string->number param)) from REQUEST-PARAMETERS (I
  think it was useless)
- I added a missing copyright header

And that's all!

Thanks for this work, it'll be very useful.  Don't hesitate send new
patches to improve it!

Best regards,
Clément

^ permalink raw reply	[flat|nested] 32+ messages in thread

end of thread, other threads:[~2018-08-13 12:26 UTC | newest]

Thread overview: 32+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-29 22:08 Web interface pushed Clément Lassieur
2018-07-29 23:46 ` Ludovic Courtès
2018-07-30 12:45   ` Pjotr Prins
2018-07-30 13:26     ` Ricardo Wurmus
2018-08-01 19:47       ` Tatiana Sholokhova
2018-08-02  6:53         ` Clément Lassieur
2018-08-02 16:00           ` Gábor Boskovits
2018-08-02 16:49             ` Clément Lassieur
2018-08-02 18:48               ` Gábor Boskovits
2018-08-02 19:21                 ` Amirouche Boubekki
2018-08-02 20:16                   ` Clément Lassieur
2018-08-02 18:13         ` Amirouche Boubekki
2018-08-02 20:17           ` Clément Lassieur
2018-08-03 13:53         ` Ricardo Wurmus
2018-08-04 21:53           ` Tatiana Sholokhova
2018-08-04 22:03             ` Ricardo Wurmus
2018-08-07 21:33               ` Tatiana Sholokhova
2018-08-09  9:17                 ` Clément Lassieur
2018-08-09 19:59                 ` amirouche
2018-08-09 20:46                 ` Ricardo Wurmus
2018-08-10  5:01                   ` Gábor Boskovits
2018-08-10  9:10                     ` Clément Lassieur
2018-08-11 16:38                       ` Ricardo Wurmus
2018-07-30  7:38 ` amirouche
2018-07-30  9:11   ` Clément Lassieur
2018-07-30  9:23     ` Alex Sassmannshausen
2018-07-30  9:41       ` Nils Gillmann
2018-07-30 12:08     ` Ricardo Wurmus
2018-07-30 12:14       ` Gábor Boskovits
2018-07-30 14:10     ` Hartmut Goebel
2018-07-30 16:02       ` Clément Lassieur
2018-07-30 18:43         ` Amirouche Boubekki

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).