From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Patchwork + automated checking and testing of patches Date: Tue, 06 Nov 2018 14:26:12 +0100 Message-ID: <87sh0e2v7v.fsf@gnu.org> References: <87h8h29z2j.fsf@cbaines.net> <87pnvostyl.fsf@gnu.org> <871s844oh0.fsf@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK1Po-0001j9-W8 for guix-devel@gnu.org; Tue, 06 Nov 2018 08:29:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK1N2-0002ht-2e for guix-devel@gnu.org; Tue, 06 Nov 2018 08:26:17 -0500 In-Reply-To: <871s844oh0.fsf@cbaines.net> (Christopher Baines's message of "Thu, 01 Nov 2018 18:55:23 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: Guix-devel Hello! Christopher Baines skribis: > Ludovic Court=C3=A8s writes: [...] >> Back when we tried, it had a couple of shortcomings: >> >> 1. It would not automatically detect which patches have been merged; >> >> 2. It would not present patch series correctly. >> >> From what you write it looks like #1 has been fixed, but the web >> interface suggests that #2 isn=E2=80=99t quite fixed yet, is that correc= t? > > On the detecting merged patches, that's definately working for some > patches though. I don't fully understand what criteria it's using > though, as it's comparing the commits that come through to the master > branch, and I bet it's possible to confuse it a bit by tweaking patches > before pushing them. > > Regarding patch series, I don't know much about the specifics of this, > and I don't know much about Patchwork, but just comparing a few patches > on the older version [1], and the newer version [2], it looks like it's > better. Take this patch [3], it's part of a series, but you can't > tell. However, with this patch [4], you can see the series and related > patches towards the top of the page, and also a link to download the > whole series as an mbox. How does this look to you? It looks better than the old Patchwork version, but I think still leaves a bit to be desired. For instance, it shows every message, even for series. At this point I find clearer and less cluttered, though it needs some improvements (e.g., most-recent-first sorting, listing all the open issues, etc.), which I think should be relatively easy to do. Also, it is directly linked to Debbugs and its notion of issues and associated properties (bug number, owner, status, tags, etc.), which is good IMO. WDYT? Thanks, Ludo=E2=80=99.