From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Sample Subject: Re: Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages) Date: Thu, 08 Aug 2019 11:54:31 -0400 Message-ID: <87sgqbmz48.fsf@ngyro.com> References: <87muh2ckdn.fsf@ngyro.com> <21D6742C-75C4-47A0-9F1A-0C911C24E3DA@vllmrt.net> <87mugmq5ll.fsf@ngyro.com> <87k1bp1aut.fsf@devup.no> <874l2spbbv.fsf@ngyro.com> <87mugjiyx0.fsf@devup.no> <8B6F734E-A186-47BB-A0E4-63DF758853EA@vllmrt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:44217) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvkkN-0007Bn-Gm for guix-devel@gnu.org; Thu, 08 Aug 2019 11:54:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvkkL-0007ae-S1 for guix-devel@gnu.org; Thu, 08 Aug 2019 11:54:35 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44807) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hvkkL-0007aM-Md for guix-devel@gnu.org; Thu, 08 Aug 2019 11:54:33 -0400 In-Reply-To: <8B6F734E-A186-47BB-A0E4-63DF758853EA@vllmrt.net> (Robert Vollmert's message of "Thu, 8 Aug 2019 15:42:44 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Robert Vollmert Cc: guix-devel@gnu.org Hi, Robert Vollmert writes: > On 8. Aug 2019, at 15:12, Marius Bakke wrote: >> I have one comment about the series: we've disabled tests on some >> packages that have been broken "forever" on i686. It would be better to >> do so selectively on just the affected architectures. I.e.: >>=20 >> #:tests? (if (string-prefix? "i686" (%current-system)) >> #f >> #t) >>=20 >> Preferably with a comment about why they need to be disabled. That way, >> we will still notice when something breaks on other architectures. Can >> you try it Rob? > > I don=E2=80=99t intend to, because I think the effort is better spent els= ewhere. > But do make the change if you like! > > The rough plan from my point of view would be to aim for an upgrade of > the haskell packages to build with ghc-8.6 from a recent stackage LTS > set, and reevaluate skipped tests across the set while doing that or > once that=E2=80=99s done. This was in the back of my mind, too. Stackage LTS 14.0 (built on top of GHC 8.6.5) was released three days ago. Upgrading will involve sweeping changes to the whole set of Haskell packages, giving us lots of opportunities to revisit these failing tests. If we still have problems with the i686 tests, we can make them conditional then. Thanks for pointing this out though, Marius. I had thought about making them conditional when reviewing, but I second guessed myself because we have a lot of packages with comments like =E2=80=9Ctests fail on architectu= re X=E2=80=9D followed by an absolute =E2=80=9C#:tests? #f=E2=80=9D. If this comes up in= the future, I=E2=80=99ll just go ahead and make the tests conditional. -- Tim