From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ABSuGjS2vl58IwAA0tVLHw (envelope-from ) for ; Fri, 15 May 2020 15:33:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YHGfFjS2vl7PMgAAB5/wlQ (envelope-from ) for ; Fri, 15 May 2020 15:33:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C93BB940146 for ; Fri, 15 May 2020 15:33:07 +0000 (UTC) Received: from localhost ([::1]:36576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZcKg-0001Dp-Ho for larch@yhetil.org; Fri, 15 May 2020 11:33:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZcKQ-0001DJ-En for guix-devel@gnu.org; Fri, 15 May 2020 11:32:50 -0400 Received: from sender4-op-o11.zoho.com ([136.143.188.11]:17106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZcKP-0000u5-C7 for guix-devel@gnu.org; Fri, 15 May 2020 11:32:50 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1589556765; cv=none; d=zohomail.com; s=zohoarc; b=YSTP09SU3LxViniHbZOoM6gUcpkDiAtArr0X7Lh4i1uFf/c6EhLCmt2UWa5MPspS7P6swfAxWe+roeDrO0ei8SZvijNOLRgXo56b1zPOERz6BM6O2OfWNaDwvnX81kcuQrJDHb1E9hnuAsMpto6QIsgymMYTKDIDaFDvGR4nva0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589556765; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=2q+ctg4eag5rLNR5NY5QCtSsayucjjMc/OYzzTsQuPU=; b=AHmOIQROltOARIj7ar6WN1n6BHX9Joy/ljEOsN99Gv0W7FEoDtP9ParwJfrXLsb1LoWDmnOSYVnb3ruWHNHAIT9sYlh5Hj7uTLJzhHmM+Tb5RDENh12i74ZgjQ0/Qzjs0BZgYUJNhupr/Gb9IZfHA32BMz3efj7ZLutMUxNOWuw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=beaver-labs.com; spf=pass smtp.mailfrom=edk@beaver-labs.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1589556765; s=zoho; d=beaver-labs.com; i=edk@beaver-labs.com; h=References:From:To:Subject:In-reply-to:Message-ID:Date:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=2q+ctg4eag5rLNR5NY5QCtSsayucjjMc/OYzzTsQuPU=; b=MnX1d383DivPYMDt2jXA0kxBEsUP11HS9CW5KONswbAf2UQq2Fc48pYecOXCjMSP n0vNq2eIsvNTRbP4MmHi6Da02Y9Qa8cwGSO8xZOjIBweaiFncD/0X4zdTdeNeir/SE+ 31+ZGw+Mp7B5pEyIAPOHFkdMKXxll2v2QpTrgKq8= Received: from alice.lan (lfbn-idf1-1-1299-119.w90-79.abo.wanadoo.fr [90.79.23.119]) by mx.zohomail.com with SMTPS id 1589556763050354.13636937370586; Fri, 15 May 2020 08:32:43 -0700 (PDT) References: <87v9kx7jh5.fsf@alice.lan> User-agent: mu4e 1.4.4; emacs 26.3 From: Edouard Klein To: guix-devel@gnu.org Subject: Re: What to do when udpating a package ? In-reply-to: Message-ID: <87sgg16wog.fsf@alice.lan> Date: Fri, 15 May 2020 17:32:31 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.11; envelope-from=edk@beaver-labs.com; helo=sender4-op-o11.zoho.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/15 11:32:47 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=beaver-labs.com header.s=zoho header.b=MnX1d383; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: jDkIFlBOBsPk Hi Julien, Thank you for your answer. Julien Lepiller writes: > Le 15 mai 2020 03:20:06 GMT-04:00, Edouard Klein a = =C3=A9crit : >>Dear Guix Developers, >> >>I have a few beginner questions. >>Attached to this email you will find the "reverse-package" graph of >>python-prompt-toolkit. > > Hi, > > In general, some packages on master may fail to build. We try to fix thes= e, but it's not always easy. > > When updating a package, you should make sure that its dependents all > build or did not build before your changes. Fix those who now fail to > build. OK, got it. I'll avoid touching those that fail to build on the build farm. > > I don't think having both versions is a good thing because it will create= conflicts when installing (have you tried to install a package that propag= ates both to a profile?). It would be ok if they had no file in common but = I doubt it is the case. For any package that requires version 2, make sure = its dependencies only use version 2, or update the package if the newer ver= sion can support version 3. It's not always easy to find the right order of= upgrades, as you should make sure nothing is broken in between patches. > I did not try to install them, and you were correct, here is what I get when I try to install python-iml: guix install: error: profile contains conflicting entries for python-prompt= -toolkit guix install: error: first entry: python-prompt-toolkit@3.0.5 /gnu/store/= 80lzvbzvfp4226ic7czhch4p0mlsdwlv-python-prompt-toolkit-3.0.5 guix install: error: ... propagated from python-ipython@7.9.0 guix install: error: ... propagated from python-iml@0.6.2 guix install: error: second entry: python-prompt-toolkit@2.0.7 /gnu/store= /0k7a0yp3b2sqqj8jhl7vp3cabb0x2mwd-python-prompt-toolkit-2.0.7 guix install: error: ... propagated from python-iml@0.6.2 hint: You cannot have two different versions or variants of `python-iml' in= the same profile. The problem is that python-iml depends on both python-ipython (which accepts python-prompt-toolkit 3) and python-prompt-toolkit-2. Looking at the github repo, the last update was in 2018, I don't think we'll see an update soon. I could pin python-ipython to python-prompt-toolkit-2, but that would just delay the problem and put it on somebody else's lap to let python-ipython move to python-prompt-toolkit 3. As I was typing a question I ctrl-Fed for 'variants' in the doc and ended up learning about package-input-rewriting. I will try to make python-iml depend on python-ipython, but with the prompt-toolkit input replaced with its version 2 on the fly. I think it makes sense. Is it the c= orrect way to do what needs to be done ? > Relying on propagated inputs to provide a dependency is going to > simplify the graphs, but not the work of other maintainers who will > have to investigate how the dependency is provided, so I don't think > it's a good idea. I understood your sentence as saying that relying on propagated inputs of propagated inputs is not a good idea and that dependencies are better explicitly stated in the guix package. Is that correct ? > > You should rebuild every dependent, even those who only depend on the > package for native-inputs, since there can be an error an any point > (though less likely). OK, I'll try that next when I'll have gotten python-iml to build. > > I hope I answered your questions. Your message was split into two > multipart sections and my client wasn't able to cite the interesting > part, which makes it hard for me to check what your questions were > while typing my answer. You have indeed answered a lot of them, thank you very much :) Sorry about the multipart stuff, I don't know how to configure my client (mu4e) not to do that. I'll look into it. Cheers, Edouard.