From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CB++AaKUvV+2OQAA0tVLHw (envelope-from ) for ; Tue, 24 Nov 2020 23:17:54 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id ICsSOaGUvV/xKQAAbx9fmQ (envelope-from ) for ; Tue, 24 Nov 2020 23:17:53 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A13629404C4 for ; Tue, 24 Nov 2020 23:17:53 +0000 (UTC) Received: from localhost ([::1]:41010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khhZI-00032w-2f for larch@yhetil.org; Tue, 24 Nov 2020 18:17:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khhZ9-00032m-U9 for guix-devel@gnu.org; Tue, 24 Nov 2020 18:17:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55702) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khhZ9-0002Lj-Nj for guix-devel@gnu.org; Tue, 24 Nov 2020 18:17:43 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38958 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1khhZ9-0000Fo-CJ for guix-devel@gnu.org; Tue, 24 Nov 2020 18:17:43 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Guix Devel Subject: Phases and snippets no longer returning a Boolean X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 Frimaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 25 Nov 2020 00:17:41 +0100 Message-ID: <87sg8ycpka.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: FsoZY3SGHd33 Hello Guix! As a followup to our recent discussion=C2=B9, I pushed the following commits to =E2=80=98core-updates=E2=80=99: 16111ad11c gnu: gcc: Phases no longer return a Boolean. 3504e39a5d gnu: base, gcc: Removing trailing #t from snippets. 325d00e619 packages: Ignore return value of origin snippets. 4cebe82fa6 build-system/texlive: Phases no longer return a Boolean. 49eadd270c build-system/minify: Phases no longer return a Boolean. 112982526f gnu: base, commencement: Remove trailing #t from build phases. 04baa011e9 build-system/gnu: Ignore the result of phase procedures. With these changes, the return value of origin snippets and build phases is now ignored. It had been deprecated, with a warning emitted at build time, since March 2018 (notably commit daac9c77b9ed25a3c0edf843fdfe5e209ebef58f). The introduction of =E2=80=98in= voke=E2=80=99 (commit 3f65c190d23296e7e718c3deff413e8beb61d8ba), which would raise an error when a program exits with non-zero, was also an enabler. Because of that I=E2=80=99m quite confident that breakage is unlikely, but we=E2=80= =99ll keep an eye on it. I only removed trailing #t in a couple of files unlikely to result in merge conflicts down the road, as Marius rightfully suggested on IRC. That=E2=80=99s it! Thoughts? Comments? #t! Ludo=E2=80=99. =C2=B9 https://lists.gnu.org/archive/html/guix-devel/2020-10/msg00332.html