From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sGMRMFoa02HyDQEAgWs5BA (envelope-from ) for ; Mon, 03 Jan 2022 16:46:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UFvCKFoa02HSPwEAG6o9tA (envelope-from ) for ; Mon, 03 Jan 2022 16:46:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4CA242ECE9 for ; Mon, 3 Jan 2022 16:46:34 +0100 (CET) Received: from localhost ([::1]:43044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4PXd-0001HR-EY for larch@yhetil.org; Mon, 03 Jan 2022 10:46:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4PXT-0001HI-JV for guix-devel@gnu.org; Mon, 03 Jan 2022 10:46:23 -0500 Received: from [2a0c:e300::1] (port=54352 helo=hera.aquilenet.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4PXR-0003of-Kn for guix-devel@gnu.org; Mon, 03 Jan 2022 10:46:23 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id A04BA363; Mon, 3 Jan 2022 16:46:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KnTx_dKw4rSs; Mon, 3 Jan 2022 16:46:17 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id ED160120; Mon, 3 Jan 2022 16:46:16 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: On raw strings in commit field References: <6e451a878b749d4afb6eede9b476e5faabb0d609.camel@gmail.com> <87k0fm7v3k.fsf@netris.org> <871r1smdu6.fsf@netris.org> <874k6nqrhs.fsf@ngyro.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 =?utf-8?Q?Niv=C3=B4se?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 03 Jan 2022 16:46:16 +0100 In-Reply-To: <874k6nqrhs.fsf@ngyro.com> (Timothy Sample's message of "Sat, 01 Jan 2022 12:45:51 -0500") Message-ID: <87sfu4hlfb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: A04BA363 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,gnu.org] X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a0c:e300::1 (failed) Received-SPF: softfail client-ip=2a0c:e300::1; envelope-from=ludo@gnu.org; helo=hera.aquilenet.fr X-Spam_score_int: 15 X-Spam_score: 1.5 X-Spam_bar: + X-Spam_report: (1.5 / 5.0 requ) RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Liliana Marie Prikler Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641224794; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=wE41TVTz/xREBsQCpxNCkQ47DRQv1eiDPeemNg/5hXQ=; b=OMpbKlVT6maZ9XbfEYBAyc5EofIM4ueJXa8YMxWcViSPag6FPwBJGktmr6P8Wdaxdq8rC0 1XE/GeM6fSwGC9r9n9ZY+0hXTLwaKw+ht6ik2Pm9zeXAtCzRxjz1QB1SGSFnvw95F3+pA9 2nHnDOyEdUfGD+ficcm8NDs70TdpsME2LmUHsafMXylSUtujSZZW8maDxI7bq1GBheuR64 QGcFXIShgQ7IlWU/PgHlvQoiWzqhSOXBO7fEDV1kFAmnGXVeKAUQB+1hrw3FgW+pedrwoz HYpDx/kva5X0GbrRZRWwcToZQyS5GiXY6oIP0b7OrHGJeh6ysxNKKGC1Fzwvng== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641224794; a=rsa-sha256; cv=none; b=PQ56HW1rxHR3xW+5hg1XVe55iIo3mfIrzx+5TDotwQLQ4LZuL3q2eH50jYshnWM5JqhcCr SLy80kRAAkeudofsR+c2B0WKnicGkyHohCMgssQJKJ6Q+4gx47hbpeaxIijKakNus/dpPe qceuFb3jvQ8m3KYhRH5Vrpk3ARiIs8a7MwFXNWJOjqDCCx7tmfpziCpHeZIb3RcoByelTf cgYNj3toRcR+kQ7uv36e+FJfplryB8QfMlZz5fDefDQRM5dwFJhpsoAWY/kXx2hcHhV6jJ DiGj6ZGU/isFH/ratTOKvr5Jmwjc8JuXyYRMvQwhN4l1Y77I/bGByLk3rzUKDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.59 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4CA242ECE9 X-Spam-Score: -3.59 X-Migadu-Scanner: scn1.migadu.com X-TUID: nJcRbxfWz8FF Hello! Timothy Sample skribis: > If you want a concrete example to think through, there=E2=80=99s =E2=80= =98eclib=E2=80=99. Our > package says it=E2=80=99s version =E2=80=9C20190909=E2=80=9D, but that=E2= =80=99s not what upstream calls > version =E2=80=9C20190909=E2=80=9D. It looks like when we packaged =E2= =80=98eclib=E2=80=99, that tag > pointed to commit 19e7e3e74268bf78bd9a1c4ba07597d5434fb166, but now it > points to bfbbd7c414521e1bf5e718a2925ea8ad845a2e87. [...] > First, as expected, finding the original commit was painful. SWH did > not record the old version of the tag. It probably did: SWH archives the =E2=80=9Chistory of histories=E2=80=9D. = However, our SWH code, =E2=80=98lookup-origin-revision=E2=80=99, is looking at the tag f= ound in the latest snapshot, which is not helpful in this case. [...] > Second, these cases are very, very rare. (I=E2=80=99ve essentially check= ed > every Git origin since Guix version 1.0.0, and this problem is not one > that worries me). =E2=80=9CTricking Peer Review=E2=80=9D-style problems = seem to be much > more prevalent. When tracking down a =E2=80=9Cdifficult=E2=80=9D Git ori= gin, the first > thing I do is grep the Guix Git history for a =E2=80=9Coops I committed t= he > wrong hash=E2=80=9D message. I recommend we focus our energies there bef= ore > worrying too much about replacing tags with commits or using both or > whatever. Agreed, it=E2=80=99d be nice to address, but not concern #1. > And as a bonus, if you want to be really kind to future time travellers, > when fixing an errant hash, please include a nice hint as to what the > original hash was for (like a commit hash). We have commit > ca5a791f6285b08506ccd662d5911ccf0c4d1ece in our repo, which says: > >> The previous hash was from the "dev" branch of the repository. > > I can=E2=80=99t find the source for the previous hash, and if I could act= ually > travel through time, I would change the commit message to: > >> The previous hash was from commit abcd0123..., which comes from the >> "dev" branch of the repository. In commit 944bd79113b9c856b11dd2b40d40e0274a9f4dd9 I added an explanation right in the source; I think that=E2=80=99s a transparent and c= lear way of handling issues with tags modified in place. Ludo=E2=80=99.