From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4LNWKdLE+GSj3AAA9RJhRA:P1 (envelope-from ) for ; Wed, 06 Sep 2023 20:28:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4LNWKdLE+GSj3AAA9RJhRA (envelope-from ) for ; Wed, 06 Sep 2023 20:28:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7AB2743DB8 for ; Wed, 6 Sep 2023 20:28:34 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Qcmc99at; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694024914; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=lbt0+N1BARiSr7oaMRq0Rp3D3In34TmMnUbSHSG2clo=; b=KNQwg2T/IrX2QAi7+IgU1VFFtlS9Kh1tkFk0SJkUnmjf7lzeRrZrjcHBbiGVZ9E4S1uW4i qghK1OSILxg+WCT0meLc2K+rQ+b45Oa2LPD5y3oSUpuEzGi/n8CZnOFoMlSUURQW34zAam jrOvJn40mjdRS0zuzQoC5RHy5h7R8DzdBv6lC39w7k7fcQIq+gXO43CHknNnu8ulgiXlF6 VITchiP7T0+U8ogVT721QqyYLLacIsGI4tcgS6GSVc98I/ys//mhg4IFj6U7SBvrq+mLms 31lE8sIKYiAh7R9EW4/PRotvei+GqTYSgLCgSchpwnlTYrbnEJ0TPlF/daQzLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694024914; a=rsa-sha256; cv=none; b=kq4365Obka9gY4hEb2Uab5kMcLypey+unvQpCEYl8KVIB3bCApRGor+NzmNZwApkFF71tp do+hGf0MWuLwh1RAWTFR4kTZjRq4/lipCRNiO8IpIFRS/zTfNDAngfB1hZCtjxr3XGuv4R /313QRsSQpohCgYoM3MdvO6YMvywq0QbyrsaAKsoozrh3NQSL3GP187EMVQR/yozAGGvF5 Dyp0+48Q314d2oPYuaVCm82B/qb8OGQYtDcKDYlpdHWFPl31EPIg5ZXGyI2XvvULB0+9CW i3f2/iPfrliYNMYJMK60DVtJILUusSmXQVudbIcoSJuAFpZwYyQswAT5Dt5mVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Qcmc99at; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdxG0-0003Sj-Rs; Wed, 06 Sep 2023 14:28:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdxFw-0003S4-3H for guix-devel@gnu.org; Wed, 06 Sep 2023 14:28:00 -0400 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdxFs-0000r6-8z for guix-devel@gnu.org; Wed, 06 Sep 2023 14:27:58 -0400 Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-76dc77fd024so8598985a.3 for ; Wed, 06 Sep 2023 11:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694024874; x=1694629674; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=lbt0+N1BARiSr7oaMRq0Rp3D3In34TmMnUbSHSG2clo=; b=Qcmc99ataplilbyYLZ2ZiimlM+rQLwVRBHtP+BxeRwlAR7VBSmW4paOg5heYOrL9BJ yL8TLwRpJ9/T15lzYpeXL3SNofnaS7tIdPu71ULezva4j6HaEVFSW5lK4XGFagrKwQ6C 5nvl+chTcBSeKccmFAl9wZfUcrmbIjLJXR12WnPczVkEM/s4oOTejyTcR91vWCM2i8z4 K7b1j54CRp5pKahFTBkQjSnK71YHbdWZ1KVYjTEfnBPt9IoBFWcxzSSAAAL7wXzW0AOz D1l7JxHALnKaTmjN+dTHCP9pS6AjVN5dDCGzAIp/rOq1xbqLI1gsYYF09aPlYlMYOIhT B5Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694024874; x=1694629674; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lbt0+N1BARiSr7oaMRq0Rp3D3In34TmMnUbSHSG2clo=; b=I0qp3yF8UyUzPAIlNJaCpFFF8BvMeKSmCdxWMJq7sh08r/kmEDBN8wU36PCfXXFd1I 0MxLtduEZ7nUlpZwQEe+Q0vwoR9mUNZ6V63B/xnh/FZ4aRE6yOtRp1kLWY/gfjIq7Tm2 Apds/p32Wv9hXVYPzyief+fYVzalYC/lak2bm/UbrzqrLA3Go2OOPM0ubdkdBJcvykga TmLWYr1ylevjp723hDefUlEpj6X9x9YlomFjB74C7BXpL3divS3HYUs6OKhbUvWUmYCC 9/7WE6qq9p586htRdKkyX/CWwVtU1noqiLtx6lp8BeFo31MCnGNZAFu+CjfU6JhKSeuq 1QlQ== X-Gm-Message-State: AOJu0Yzrzi4wNnHks3EX5snKttm0U7SV1SmYteH0QIh8Cd5KJyUf3wIc IGJ2/B5adWyqS3PWWrNigjHduWueWVVC9g== X-Google-Smtp-Source: AGHT+IGMla2dAtZHsJ1ldVvFM7bOqv0uvTdCxbC08Tcccsxvk4WvDhtrmcnUDTOkCEXNLjwDhtHwOQ== X-Received: by 2002:a05:620a:414b:b0:76f:167d:36f6 with SMTP id k11-20020a05620a414b00b0076f167d36f6mr19261876qko.62.1694024873952; Wed, 06 Sep 2023 11:27:53 -0700 (PDT) Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125]) by smtp.gmail.com with ESMTPSA id g9-20020a05620a13c900b0076dae4753efsm5154831qkl.14.2023.09.06.11.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 11:27:53 -0700 (PDT) From: Maxim Cournoyer To: Vagrant Cascadian Cc: Liliana Marie Prikler , brian , "(" , Katherine Cox-Buday , Simon Tournier , Saku Laesvuori , Attila Lendvai , Andreas Enge , guix-devel@gnu.org Subject: Re: How can we decrease the cognitive overhead for contributors? References: <20230827135726.y33t55w4cvq6zsvb@X-kone> <874jkift8v.fsf@gmail.com> <867cp4sj7k.fsf@gmail.com> <38242808-2f06-4674-3842-aea1a5378d05@gmail.com> <87a5u0o3z2.fsf@disroot.org> <87sf7s9oi9.fsf@spork.org> <67115f26712acbb1d83b71f4418c682a5e9762a4.camel@gmail.com> <87h6o7mbo2.fsf@wireframe> Date: Wed, 06 Sep 2023 14:27:51 -0400 In-Reply-To: <87h6o7mbo2.fsf@wireframe> (Vagrant Cascadian's message of "Wed, 06 Sep 2023 10:52:45 -0700") Message-ID: <87sf7rqhqw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::72f; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x72f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -7.08 X-Migadu-Queue-Id: 7AB2743DB8 X-Migadu-Spam-Score: -7.08 X-TUID: lSVArFi0jH8X Hi Vagrant, Vagrant Cascadian writes: > On 2023-09-06, Liliana Marie Prikler wrote: >> Am Dienstag, dem 05.09.2023 um 19:41 -0400 schrieb brian >>> =E2=80=98* foo/bar.scm new-package (inputs): add input=E2=80=99 >>>=20 >>> stuff. I literally can never remember this format, no matter how many >>> times I do it. I'm reasonably sure square brackes go in there some >>> where. It can take me quite a while to put together all that stuff, >>> even with magit's help. >> It's=20 >> >> * file (variable)[field]{do you need 4 levels?} > > Honestly, not knowing the difference between a variable and field and > selector... this comment is of little help to me. > > I always get tripped up with phases, modify-phases, etc. as there seem > to be potentially four or more levels deep in some common code > patterns... for example, a recent commit mentioning phases: The ChangeLog Style section suggests there should be spaces between the "markers". It also says the square brackets should be used to denote a change made in a conditional code path, so we're abusing the meaning of it in Guix to just a 'field' (which is, a record field, or slot, for the record in Guix). < > is to precise even more the place modified. They're just shortcuts to avoid less typing while remaining readable. Here's an example in the Guix "dialect": --8<---------------cut here---------------start------------->8--- * gnu/packages/file.scm (package-symbol) [arguments] <#:phases>: New patch-paths phase. --8<---------------cut here---------------end--------------->8--- It could also have been: --8<---------------cut here---------------start------------->8--- * gnu/packages/file.scm (package-symbol) [arguments]: Add patch-paths phase. --8<---------------cut here---------------end--------------->8--- It doesn't really matter, as long as it's clear and you did the exercise of reviewing the code you touched and writing down the changes summary for the reviewer (and yourself). =20=20 --=20 Thanks, Maxim