From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Add Mercurial to version-control.scm
Date: Sat, 07 Sep 2013 15:06:20 +0200
Message-ID: <87r4d06asz.fsf@gnu.org>
References: <8738piqor3.wl%arne_bab@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47263)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VIIIS-0001KY-Fg
	for guix-devel@gnu.org; Sat, 07 Sep 2013 09:11:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VIIIM-0005Wu-98
	for guix-devel@gnu.org; Sat, 07 Sep 2013 09:11:28 -0400
Received: from hera.aquilenet.fr ([141.255.128.1]:41798)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VIIIM-0005Wp-2u
	for guix-devel@gnu.org; Sat, 07 Sep 2013 09:11:22 -0400
In-Reply-To: <8738piqor3.wl%arne_bab@web.de> (Arne Babenhauserheide's message
	of "Fri, 06 Sep 2013 11:32:32 +0200")
List-Id: <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Arne Babenhauserheide <arne_bab@web.de>
Cc: guix-devel@gnu.org

Hi Arne,

Arne Babenhauserheide <arne_bab@web.de> skribis:

> Here=E2=80=99s a patch to add Mercurial as package:

Thanks for the patch!

It looks good overall.  I=E2=80=99m assuming that it actually builds, is us=
able,
and that you assert that you did a reasonable auditing setting the
=E2=80=98license=E2=80=99 field.

A few stylistic comments.

First, could you send the patch as produced by =E2=80=98git format-patch=E2=
=80=99, which
a ChangeLog-style commit log (see =E2=80=98HACKING=E2=80=99 and the VCS his=
tory for
details)?  Then we=E2=80=99ll happily push it.  :-)

> +(define-public mercurial
> +  (package
> +    (name "mercurial")
> +    (version "2.7.1")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "http://mercurial.selenic.com/release/mercuria=
l-" version ".tar.gz"))

Please keep lines below 80 columns (see =E2=80=98Coding Style=E2=80=99 in =
=E2=80=98HACKING=E2=80=99.)

> +      (sha256
> +       (base32
> +        "121m8f7vmipmdg00cnzdz2rjkgydh28mwfirqkrbs5fv089vywl4"))))
> +    (build-system python-build-system)
> +    (home-page "http://mercurial.selenic.com")
> +    (synopsis "Decentralized version control system")
> +    (description
> +     "Mercurial is a free, distributed source control management tool.=20
> +It efficiently handles projects of any size and offers an easy and intui=
tive interface.")

Likewise.

> I put Mercurial between bazaar and subversion to keep alphabetic
> ordering. Later items might not be ordered alphabetically, but that=E2=80=
=99s
> out of my responsibility :)

Yes, we=E2=80=99re pretty liberal in that regard.  ;-)

Thanks for your patch, and welcome aboard!

Ludo=E2=80=99.