From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/5] gnu: libxml2: Fixed cross-compilation. Date: Sat, 14 Dec 2013 18:48:27 +0100 Message-ID: <87r49fuxw4.fsf@gnu.org> References: <1387043002-6138-1-git-send-email-john@darrington.wattle.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrtKN-000622-Bj for guix-devel@gnu.org; Sat, 14 Dec 2013 12:48:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrtKG-00013a-VR for guix-devel@gnu.org; Sat, 14 Dec 2013 12:48:35 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:41958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrtKG-00013S-Ol for guix-devel@gnu.org; Sat, 14 Dec 2013 12:48:28 -0500 In-Reply-To: <1387043002-6138-1-git-send-email-john@darrington.wattle.id.au> (John Darrington's message of "Sat, 14 Dec 2013 18:43:18 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: John Darrington Cc: guix-devel@gnu.org John Darrington skribis: > * gnu/packages/xml.scm (libxml2): [(eq? (%current-target-system) #f)] ass= ign "cross-libc" > to the variable glibc No need to show the condition in the log. > --- a/gnu/packages/xml.scm > +++ b/gnu/packages/xml.scm > @@ -75,7 +75,7 @@ things the parser might find in the XML document (like = start tags).") > 'install > (lambda* (#:key inputs outputs #:allow-other-keys #:rest args) > (let ((install (assoc-ref %standard-phases 'install)) > - (glibc (assoc-ref inputs "libc")) > + (glibc (assoc-ref inputs ,(if (%current-target-system) "= cross-libc" "libc"))) Please wrap lines under 80 chars. Could you send the updated patch? Thanks, Ludo=E2=80=99.