From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: xterm: Accept $SHELL even if not in /etc/shells
Date: Fri, 14 Feb 2014 11:59:32 +0100
Message-ID: <87r4763qp7.fsf@gnu.org>
References: <87zjlvh276.fsf@netris.org> <20140213080720.GA28268@jocasta.intra>
	<87txc3h005.fsf@netris.org> <871tz7p354.fsf@gnu.org>
	<87ha83m0wg.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41080)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WEGUf-0004bD-An
	for guix-devel@gnu.org; Fri, 14 Feb 2014 05:59:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WEGUY-0007Rg-6g
	for guix-devel@gnu.org; Fri, 14 Feb 2014 05:59:41 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:45578)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WEGUX-0007Ra-W6
	for guix-devel@gnu.org; Fri, 14 Feb 2014 05:59:34 -0500
In-Reply-To: <87ha83m0wg.fsf@netris.org> (Mark H. Weaver's message of "Thu, 13
	Feb 2014 11:29:35 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> IMO, it's not reasonable to have to add
>>> /home/<USER>/<PROFILE>/bin/<SHELL> for every combination of <USER>,
>>> <PROFILE>, and <SHELL> to /etc/shells, in order to prevent 'xterm' from
>>> overriding your $SHELL setting.
>>
>> On NixOS, /etc/shells contains this:
>>
>> /run/current-system/sw/bin/bash
>> /var/run/current-system/sw/bin/bash
>> /bin/sh
>>
>> Where {/var/,}/run/current-system contains the =E2=80=9Cglobal=E2=80=9D =
profile, like on
>> our QEMU images.
>>
>> Perhaps that=E2=80=99s good enough no?
>
> If a user wants to set $SHELL to be the one in their private profile,
> I think 'xterm' shouldn't ignore it and modify $SHELL just because it
> hasn't been authorized by the administrator of the system.

Agreed.

However, we=E2=80=99re just packaging an existing application.  IMO, when we
find such limitations (it=E2=80=99s really a limitation, and not something =
that
makes it completely unusable), we should submit the improvement
upstream, unless upstream no longer exists (I=E2=80=99m not sure if this is=
 the
case here.)

WDYT?

Thanks!

Ludo=E2=80=99.