From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Python: disable test_wait_result() as it fails on some setups Date: Mon, 07 Apr 2014 02:17:35 -0400 Message-ID: <87r459slxc.fsf@yeeloong.lan> References: <87ppkuxn2h.fsf@gnu.org> <1396820010-19125-1-git-send-email-tipecaml@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX2tY-0001El-5H for guix-devel@gnu.org; Mon, 07 Apr 2014 02:19:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WX2tT-0002Cn-3Q for guix-devel@gnu.org; Mon, 07 Apr 2014 02:19:00 -0400 Received: from world.peace.net ([96.39.62.75]:46040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX2tS-0002CP-RJ for guix-devel@gnu.org; Mon, 07 Apr 2014 02:18:55 -0400 In-Reply-To: <1396820010-19125-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Sun, 6 Apr 2014 23:33:30 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Cyril Roelandt Cc: guix-devel@gnu.org Cyril Roelandt writes: > * gnu/packages/patches/python-fix-tests.patch: disable a failing test. > --- > gnu/packages/patches/python-fix-tests.patch | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/gnu/packages/patches/python-fix-tests.patch b/gnu/packages/patches/python-fix-tests.patch > index fecebda..eed4f36 100644 > --- a/gnu/packages/patches/python-fix-tests.patch > +++ b/gnu/packages/patches/python-fix-tests.patch > @@ -64,3 +64,13 @@ http://bugs.python.org/issue20868 . > @unittest.skipUnless(support.is_resource_enabled('network'), > 'network is not enabled') > def test_idna(self): > +--- Lib/test/test_multiprocessing.py 2014-04-06 23:12:27.575235000 +0200 > ++++ Lib/test/test_multiprocessing.py 2014-04-06 23:13:04.827235000 +0200 > +@@ -1016,6 +1016,7 @@ > + if pid is not None: > + os.kill(pid, signal.SIGINT) > + > ++ @unittest.skipIf(True, "This fails for unknown reasons on Guix") > + def test_wait_result(self): > + if isinstance(self, ProcessesMixin) and sys.platform != 'win32': > + pid = os.getpid() This fixes the build on x86_64 for me, but there are still test failures on MIPS: --8<---------------cut here---------------start------------->8--- ====================================================================== FAIL: test_issue_8959_a (ctypes.test.test_callbacks.SampleCallbacksTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/tmp/nix-build-python-3.3.3.drv-0/Python-3.3.3/Lib/ctypes/test/test_callbacks.py", line 191, in test_issue_8959_a self.assertEqual(array[:], [1, 5, 7, 33, 99]) AssertionError: Lists differ: [33, 7, 99, 1, 5] != [1, 5, 7, 33, 99] First differing element 0: 33 1 - [33, 7, 99, 1, 5] + [1, 5, 7, 33, 99] ====================================================================== FAIL: test_qsort (ctypes.test.test_libc.LibTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/tmp/nix-build-python-3.3.3.drv-0/Python-3.3.3/Lib/ctypes/test/test_libc.py", line 30, in test_qsort self.assertEqual(chars.raw, b" ,,aaaadmmmnpppsss\x00") AssertionError: b'mmaappss dna ,,maps\x00' != b' ,,aaaadmmmnpppsss\x00' ---------------------------------------------------------------------- Ran 346 tests in 4.092s FAILED (failures=2, skipped=1) Makefile:881: recipe for target 'test' failed make: *** [test] Error 1 phase `check' failed after 661 seconds --8<---------------cut here---------------end--------------->8--- I suppose that these are genuine bugs in the ctypes module for MIPS. Mark