[PATCH] gnu: Propagate necessary inputs for sdl-image

[PATCH] gnu: Propagate necessary inputs for sdl-image

[David Thompson]

[-- Attachment #1: Type: text/plain, Size: 123 bytes --]

The libraries for loading JPG, PNG, and TIFF images need to be
propagated inputs in order for SDL image to work properly.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Propagate-necessary-inputs-for-sdl-image.patch --]
[-- Type: text/x-diff, Size: 1389 bytes --]

From 6b3dfa3d5ad01efa29494f34f093fa1aa2dad437 Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson@member.fsf.org>
Date: Wed, 30 Apr 2014 20:35:45 -0400
Subject: [PATCH 1/2] gnu: Propagate necessary inputs for sdl-image.

* gnu/packages/sdl.scm (sdl-image): Propagate jpeg, png, and tiff
  libraries.
---
 gnu/packages/sdl.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
index d86ecde..713700d 100644
--- a/gnu/packages/sdl.scm
+++ b/gnu/packages/sdl.scm
@@ -147,12 +147,12 @@ other supporting functions for SDL.")
               (base32
                "16an9slbb8ci7d89wakkmyfvp7c0cval8xw4hkg0842nhhlp540b"))))
     (build-system gnu-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)))
     ;; FIXME: Add webp
-    (inputs `(("libpng" ,libpng)
-              ("libjpeg" ,libjpeg)
-              ("libtiff" ,libtiff)
-              ("pkg-config" ,pkg-config)))
-    (propagated-inputs `(("sdl" ,sdl)))
+    (propagated-inputs `(("sdl" ,sdl)
+                         ("libjpeg" ,libjpeg)
+                         ("libpng" ,libpng)
+                         ("libtiff" ,libtiff)))
     (synopsis "SDL image loading library")
     (description "SDL_image is an image file loading library for SDL that
 supports the following formats: BMP, GIF, JPEG, LBM, PCX, PNG, PNM, TGA, TIFF,
-- 
1.8.4

Re: [PATCH] gnu: Propagate necessary inputs for sdl-image

[Andreas Enge]

On Wed, Apr 30, 2014 at 08:40:56PM -0400, David Thompson wrote:
> The libraries for loading JPG, PNG, and TIFF images need to be
> propagated inputs in order for SDL image to work properly.

Looks good, can you push, please?

Andreas

Re: [PATCH] gnu: Propagate necessary inputs for sdl-image

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> The libraries for loading JPG, PNG, and TIFF images need to be
> propagated inputs in order for SDL image to work properly.

Could you add a comment saying why this is the case?

This is usually one of:

  1. SDL_image headers include libjpeg etc. headers;
  2. sdl-image.pc refers to libjpeg.pc etc.

Ludo’.

Re: [PATCH] gnu: Propagate necessary inputs for sdl-image

[David Thompson]

Ludovic Courtès <ludo@gnu.org> writes:

> David Thompson <dthompson2@worcester.edu> skribis:
>
>> The libraries for loading JPG, PNG, and TIFF images need to be
>> propagated inputs in order for SDL image to work properly.
>
> Could you add a comment saying why this is the case?
>
> This is usually one of:
>
>   1. SDL_image headers include libjpeg etc. headers;
>   2. sdl-image.pc refers to libjpeg.pc etc.
>
> Ludo’.

Done and pushed.  Thanks.

- Dave