From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 5/6] gnu: Enable gnome-doc-utils tests Date: Tue, 15 Jul 2014 22:59:17 +0200 Message-ID: <87r41ml4nu.fsf@gnu.org> References: <1405449096-29230-1-git-send-email-jmd@gnu.org> <1405449096-29230-5-git-send-email-jmd@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X79os-00010z-Bh for guix-devel@gnu.org; Tue, 15 Jul 2014 16:59:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X79om-00039c-UI for guix-devel@gnu.org; Tue, 15 Jul 2014 16:59:26 -0400 In-Reply-To: <1405449096-29230-5-git-send-email-jmd@gnu.org> (John Darrington's message of "Tue, 15 Jul 2014 20:31:35 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: John Darrington Cc: guix-devel@gnu.org John Darrington skribis: > * gnu/packages/gnome (gnome-doc-utils): Set the XML_CATALOG_FILES variabl= e and > enable the tests. OK to push for now, but: > + (arguments > + `(#:phases > + (alist-cons-before > + 'check 'pre-check > + (lambda* (#:key inputs #:allow-other-keys #:rest args) > + ;; This is needed, because without it, xmlint etc tries > + ;; to download docbookx.dtd from the net > + (setenv "XML_CATALOG_FILES"=20 > + (string-append (assoc-ref inputs "docbook-xml")=20 > + "/xml/dtd/docbook/catalog.xml"))) > + %standard-phases))) > (native-inputs > `(("intltool" ,intltool) > + ("docbook-xml" ,docbook-xml-4.4) We can=E2=80=99t copy that around forever. The problem is that =E2=80=98search-path-specification=E2=80=99 is meant fo= r $PATH-like variables that list directories, not files. So I see two solutions: 1. Patch libxml2 so that it honors a new variable, say $XML_CATALOG_DIRECTORIES, which would allow us to use =E2=80=98search-path-specification=E2=80=99. 2. Augment support for search paths to allow file-based search paths. (2) may be best in the long run, but it has ramifications in different places. Thoughts? Ludo=E2=80=99.