From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: aegis: New variable.
Date: Thu, 17 Jul 2014 17:00:40 +0200
Message-ID: <87r41kdo87.fsf@gnu.org>
References: <1405518437-24315-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55744)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X7nAv-0002wx-Dk
	for guix-devel@gnu.org; Thu, 17 Jul 2014 11:00:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X7nAo-0002L7-Vr
	for guix-devel@gnu.org; Thu, 17 Jul 2014 11:00:49 -0400
In-Reply-To: <1405518437-24315-1-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Wed, 16 Jul 2014 15:47:17 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

Hi,

Please write =E2=80=9Cgnu: Add Aegis.=E2=80=9D in the summary line.  =E2=80=
=9CNew variable=E2=80=9D is
when referring to the variable itself in the ChangeLog part.

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/version-control.scm (aegis): New variable.
> * gnu/packages/patches/aegis-constness-error.patch: New file.
> * gnu/packages/patches/aegis-perl-tempdir1.patch: New file.
> * gnu/packages/patches/aegis-perl-tempdir2.patch: New file.
> * gnu/packages/patches/aegis-test-fixup-1.patch: New file.
> * gnu/packages/patches/aegis-test-fixup-2.patch: New file.

Could you merge tempdir1 and tempdir2, as well as fixup1 and fixup2?

> +++ b/gnu/packages/patches/aegis-constness-error.patch
> @@ -0,0 +1,12 @@
> +Fixes a fatal constness error with g++ 4.8.2

Period.

> +++ b/gnu/packages/patches/aegis-perl-tempdir1.patch
> @@ -0,0 +1,14 @@
> +This patch removes the hard coded tmp dir (which might not exist on the =
system)
> +and replaces it using the perl prefered method

Period, =E2=80=9Ctemporary directory=E2=80=9D, =E2=80=9CPerl=E2=80=9D, =E2=
=80=9Cpreferred=E2=80=9D.

> +++ b/gnu/packages/patches/aegis-test-fixup-1.patch
> @@ -0,0 +1,15 @@
> +This test fails because it expects a mimetype "Content-Type: image/gif"

=E2=80=9CMIME type=E2=80=9D.

> +;; This package can unfortunately work only in -TEST mode, since aegis ;;

=E2=80=9CAegis=E2=80=9D.  Extran semicolon.

> +;; requires that it is installed setuid root, which is not currently pos=
sible
> +;; in Guix (hopefully in forthcoming versions this will change).

Remove =E2=80=9C, which is not...=E2=80=9D.  :-)

The package itself cannot install things setuid (nothing can be setuid
in the store), but there can be setuid programs in the system (see
gnu/system.scm.)

> +(define-public aegis
> +  (package
> +    (name "aegis")
> +    (version "4.24")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/aegis/aegis-" ve=
rsion ".tar.gz"))

Line length.

OK to push with these changes.

Thanks!

Ludo=E2=80=99.