From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 01/13] gnu: subversion: Propagate env variables to hooks.
Date: Tue, 25 Nov 2014 09:03:23 +0100
Message-ID: <87r3wriu5w.fsf@gnu.org>
References: <1416548468-28421-1-git-send-email-bavier@member.fsf.org>
	<1416548468-28421-2-git-send-email-bavier@member.fsf.org>
	<871towp5ze.fsf@gnu.org> <87ppcgtcoj.fsf@gmail.com>
	<CADwNbn_+Md_5RKQoCZnCzxzhBazD20+wYbM-2-7dMsNy2riZ1A@mail.gmail.com>
	<87k32njy58.fsf@gnu.org>
	<CADwNbn9FUcUi85PHhNttbzw=Sp9HhSzQFKbL0U8N-=j3Ncvfng@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XtB63-0000S5-U6
	for guix-devel@gnu.org; Tue, 25 Nov 2014 03:03:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XtB5u-0001PX-EU
	for guix-devel@gnu.org; Tue, 25 Nov 2014 03:03:39 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:39192)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XtB5u-0001PN-8U
	for guix-devel@gnu.org; Tue, 25 Nov 2014 03:03:30 -0500
In-Reply-To: <CADwNbn9FUcUi85PHhNttbzw=Sp9HhSzQFKbL0U8N-=j3Ncvfng@mail.gmail.com>
	(Eric Bavier's message of "Mon, 24 Nov 2014 23:42:55 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>, Eric Bavier <bavier@member.fsf.org>

Eric Bavier <ericbavier@gmail.com> skribis:

> The culprit, I think, is a small difference in behavior of bash.  If PATH
> is unset (such as within svn's hook environment), then `bash -c 'echo
> $PATH'` on an FHS system prints something like
> "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin", but Guix's
> bash prints "/no-such-path".  In the first case, `ls` will resolve to
> "/bin/ls", but will not be found in the second.

OK.  The /no-such-path comes from the compile-time settings of our Bash,
in (gnu packages bash).

We could perhaps fix it to refer to Coreutils, but that=E2=80=99s a bit tri=
cky.

(Similarly, =E2=80=98getconf PATH=E2=80=99 with our libc returns something =
non-sensical,
but I=E2=80=99m not sure what can be done about it.)

> Given that behavior, people have nothing to work around.  Does Nix's bash
> behave differently?

No.

> I'm not sure that our bash needs to be changed in any way.  It's current
> behavior seems in line with Guix's way of things.

Yes.

> I was able to get the tests to pass by simply patching the references to =
ls
> that libtool emits in its wrappers.  I think this might be the way to go
> for now,

Yes, sounds good.

> while also submitting a bug to libtool.

I don=E2=80=99t think so.  Often, the problem is when such scripts contain
absolute file names, like /usr/bin/file, which we need to patch.  This
time they=E2=80=99re =E2=80=9Cdoing it right=E2=80=9D, so let=E2=80=99s not=
 suggest the evil thing.  :-)

Thanks,
Ludo=E2=80=99.