From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] gnu: Add ngircd.
Date: Thu, 05 Feb 2015 10:46:04 -0500
Message-ID: <87r3u44b0j.fsf@netris.org>
References: <87sieqr574.fsf@taylan.uni.cx> <87k302qz8h.fsf@taylan.uni.cx>
	<874mr6f791.fsf@netris.org> <87fvapjjx9.fsf@taylan.uni.cx>
	<87twz034rf.fsf@gnu.org> <877fvw2zvh.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48191)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YJOdM-0002ck-2k
	for guix-devel@gnu.org; Thu, 05 Feb 2015 10:46:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YJOdF-0003M5-Up
	for guix-devel@gnu.org; Thu, 05 Feb 2015 10:46:24 -0500
In-Reply-To: <877fvw2zvh.fsf@taylan.uni.cx> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Thu, 05 Feb 2015 15:32:02 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer=22?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") writes:

> +    (arguments
> +     `(#:configure-flags
> +       `("--with-gnutls" "--with-iconv" "--enable-ipv6"
> +         ,,@(if (string-suffix? "-linux"
> +                                (or (%current-target-system)
> +                                    (%current-system)))
> +                '("--with-pam")
> +                '()))

There's no need for two levels of quasiquote here, and it unnecessarily
complicates the unquoting.  How about changing the inner quasiquote to
normal quote?  It should come out like this:

    (arguments
     `(#:configure-flags
       '("--with-gnutls" "--with-iconv" "--enable-ipv6"
         ,@(if (string-suffix? "-linux"
                               (or (%current-target-system)
                                   (%current-system)))
               '("--with-pam")
               '()))

> +       #:phases
> +       ;; Necessary for the test suite, should it be enabled in the futu=
re.

You can remove the ", should it be enabled in the future".

Modulo these little nitpicks, it looks good to me.  Please push!

     Thanks,
       Mark