From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 01/01: gnu: Add agg.
Date: Wed, 18 Mar 2015 14:09:49 +0100
Message-ID: <87r3smfo4i.fsf@gnu.org>
References: <20150318105410.2359.97929@vcs.savannah.gnu.org>
	<E1YYBc3-0000d6-3W@vcs.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55644)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YYDjR-0001G3-JS
	for guix-devel@gnu.org; Wed, 18 Mar 2015 09:09:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YYDjO-0007Qo-DR
	for guix-devel@gnu.org; Wed, 18 Mar 2015 09:09:57 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50970)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YYDjO-0007Qh-5r
	for guix-devel@gnu.org; Wed, 18 Mar 2015 09:09:54 -0400
In-Reply-To: <E1YYBc3-0000d6-3W@vcs.savannah.gnu.org> (Tomas Cech's message of
	"Wed, 18 Mar 2015 10:54:11 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= <sleep_walker@gnu.org>
Cc: guix-devel@gnu.org

Tomas Cech <sleep_walker@suse.cz> skribis:

> commit 87bafa07ae68084819bb2648bd1042c354d11317
> Author: Tom=C3=A1=C5=A1 =C4=8Cech <sleep_walker@gnu.org>
> Date:   Wed Mar 18 08:57:50 2015 +0100
>
>     gnu: Add agg.
>=20=20=20=20=20
>     * gnu/packages/graphics.scm (agg): New variable.
>     * gnu/packages/patches/agg-am_c_prototype.patch: New file.
>     * gnu-system.am (dist_patch_DATA): Add it.

[...]

> +++ b/gnu/packages/patches/agg-am_c_prototype.patch
> @@ -0,0 +1,10 @@
> +--- a/configure.in	2015-03-15 18:59:12.557417149 +0100
> ++++ b/configure.in	2015-03-15 18:59:29.273416518 +0100

Patches must have a comment at the beginning to explain what they do,
why, and what the upstream status is.

Please pay more attention to these rules before pushing.  In general, I
would recommend that you wait for some review before pushing.  (This is
sometimes slow, but hopefully others will help reduce latency,
hint hint! ;-))

> +@@ -8,7 +8,6 @@
> + AC_PROG_CC
> + AC_PROG_CXX
> + AC_ISC_POSIX
> +-AM_C_PROTOTYPES
> + if test "x$U" !=3D "x"; then
> +   AC_MSG_ERROR(Compiler not ANSI compliant)
> + fi

It is best to avoid modifying .ac or .am files because that requires
adding a dependency on the autotools.

What problem does this patch solve?  I=E2=80=99m confident this can be work=
ed
around without modifying the .ac file, for instance by passing the right
ac_cv_ variable as a =E2=80=98configure=E2=80=99 argument.

Thanks,
Ludo=E2=80=99.