From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add Csound and Solfege.
Date: Tue, 07 Apr 2015 08:36:23 +0200 [thread overview]
Message-ID: <87r3rwcumw.fsf@mango.localdomain> (raw)
In-Reply-To: <87fv8hjn7c.fsf@gnu.org>
Ludovic Courtès writes:
> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> patch-python-shebangs
>> : Self-explanatory. As at least one file is in ISO-8859 encoding this
>> whole thing is wrapped in (with-fluids ((%default-port-encoding #f))
>> ...)
>
> Why doesn’t the ‘patch-shebangs’ phase do its job? Could
> ‘patch-shebang’ be used instead of ‘substitute*’?
The two affected files start with a Unicode BOM. I simplified the phase
a little more, because it's really only two files that need this special
treatment, not all Python scripts.
>> adjust-config-file-prefix
>> : Config files are usually loaded from /etc or /usr/share. This
>> phase sets the prefix to the package output directory.
>
> OK. I suppose Solfege also supports reading per-user config files from
> ~/.config or similar?
It also reads ~/.solfegerc, but the default config file is used to
initialise the user config if it doesn't exist.
>> fix-gettext
>> : I have no idea what's wrong with the i18n of Solfege. Upon
>> application start I'm greeted with locale errors and this particular
>> line looks like just wrong. "i18n" is None at this point and the
>> application just crashes unless I comment the line. I feel least
>> comfortable with this hack and I'd be glad if someone could find a
>> fix that makes this phase obsolete.
>
> I don’t know what the Python API looks like. The gettext manual
> mentions an API with the ‘gettext.’ prefix, dunno if that’s a different
> thing.
I was wrong. Not i18n is None, but i18n.translation is. Dependent on
locale environment variables it will be set to hold the appropriate
translations. In my case this didn't work for the following reasons:
* glibc-locales was not installed to my profile
* LOCPATH was not set to $out:/lib/locales of glibc-locales
* LC_ALL was not set; when I set it to en_GB it works fine
Since it works in a correctly configured environment I removed the
phase.
> OK to push with these changes!
Thanks for the review! Pushed.
~~ Ricardo
prev parent reply other threads:[~2015-04-07 6:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 20:57 [PATCH] Add Csound and Solfege Ricardo Wurmus
2015-04-03 14:33 ` Ludovic Courtès
2015-04-07 6:36 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3rwcumw.fsf@mango.localdomain \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).