From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] Add libsvm. Date: Thu, 28 May 2015 15:56:59 -0400 Message-ID: <87r3q0wk50.fsf@netris.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yy3vW-0006V0-82 for guix-devel@gnu.org; Thu, 28 May 2015 15:57:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yy3vS-00043F-Ol for guix-devel@gnu.org; Thu, 28 May 2015 15:57:14 -0400 Received: from world.peace.net ([50.252.239.5]:45443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yy3vS-000438-LL for guix-devel@gnu.org; Thu, 28 May 2015 15:57:10 -0400 In-Reply-To: (Ricardo Wurmus's message of "Thu, 28 May 2015 16:39:31 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: Guix-devel Hi Ricardo. Please see below for comments. Ricardo Wurmus writes: > From bbd4a72d89762f93816cfe4ed917c55ffe19bac8 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Thu, 28 May 2015 15:53:14 +0200 > Subject: [PATCH] gnu: Add libsvm. > > * gnu/packages/machine-learning.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > --- > gnu-system.am | 1 + > gnu/packages/machine-learning.scm | 72 +++++++++++++++++++++++++++++++++= ++++++ > 2 files changed, 73 insertions(+) > create mode 100644 gnu/packages/machine-learning.scm > > diff --git a/gnu-system.am b/gnu-system.am > index 43ced12..c699da8 100644 > --- a/gnu-system.am > +++ b/gnu-system.am > @@ -196,6 +196,7 @@ GNU_SYSTEM_MODULES =3D \ > gnu/packages/lxqt.scm \ > gnu/packages/lynx.scm \ > gnu/packages/m4.scm \ > + gnu/packages/machine-learning.scm \ > gnu/packages/man.scm \ > gnu/packages/mail.scm \ > gnu/packages/make-bootstrap.scm \ > diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-lea= rning.scm > new file mode 100644 > index 0000000..e368fc5 > --- /dev/null > +++ b/gnu/packages/machine-learning.scm > @@ -0,0 +1,72 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2015 Ricardo Wurmus > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages machine-learning) > + #:use-module ((guix licenses) #:prefix license:) > + #:use-module (guix packages) > + #:use-module (guix utils) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:use-module (gnu packages)) > + > +(define-public libsvm > + (package > + (name "libsvm") > + (version "3.20") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/cjlin1/libsvm/archive/v" > + (string-join (string-split version #\.) "") ".tar.gz")) (string-delete #\. version) Also, please add a 'file-name' field so that the source filename in the store will be called *-libsvm-3.20.tar.gz instead of *-v320.tar.gz. > + (sha256 > + (base32 > + "1jpjlql3frjza7zxzrqqr2firh44fjb8fqsdmvz6bjz7sb47zgp4")))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ;no "check" target > + #:phases (modify-phases %standard-phases > + (delete 'configure) > + (add-after > + 'build 'build-library > + (lambda _ > + (zero? (system* "make" "lib")))) (zero? (system* "make" "-j" (number->string (parallel-job-count)) "lib")) > + (replace > + 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin/")) > + (lib (string-append out "/lib/"))) > + (mkdir-p lib) > + (mkdir bin) > + (for-each (lambda (file) > + (copy-file file (string-append bin fi= le))) > + '("svm-train" > + "svm-predict" > + "svm-scale")) > + (copy-file "libsvm.so.2" > + (string-append lib "libsvm.so.2"))) I tried building this, I noticed that the installed binaries (svm-train, svm-predict, and scm-scale) don't reference libsvm.so.2. In the build output, I see no header files and no libsvm.so symlink, so I don't see how this library could be used. Thanks, Mark