From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable Date: Fri, 26 Jun 2015 16:32:59 +0300 Message-ID: <87r3oylhmc.fsf@gmail.com> References: <87r3p2r6od.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8Tkf-00053z-Cx for guix-devel@gnu.org; Fri, 26 Jun 2015 09:33:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8Tkc-0002Fq-0w for guix-devel@gnu.org; Fri, 26 Jun 2015 09:33:05 -0400 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:36128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8Tkb-0002FT-Pf for guix-devel@gnu.org; Fri, 26 Jun 2015 09:33:01 -0400 Received: by lacny3 with SMTP id ny3so63608981lac.3 for ; Fri, 26 Jun 2015 06:33:00 -0700 (PDT) In-Reply-To: ("Claes Wallin \=\?utf-8\?B\?KOmfi+WYieiqoCkiJ3M\=\?\= message of "Wed, 24 Jun 2015 23:35:00 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?Q2xhZXMgV2FsbGluICjpn4vlmInoqqAp?= Cc: guix-devel Claes Wallin (=E9=9F=8B=E5=98=89=E8=AA=A0) (2015-06-25 00:35 +0300) wrote: > On Tue, Jun 23, 2015 at 1:43 PM, Alex Kost wrote: > >> --8<---------------cut here---------------start------------->8--- >> gnu: Add pv. >> >> * gnu/package/pv.scm (pv): New file. >> * gnu-system.am (GNU_SYSTEM_MODULES): Add it. >> --8<---------------cut here---------------end--------------->8--- >> >> And you also need to add "gnu/package/pv.scm" to "gnu-system.am". See >> commit 741115b for example. > >> IIUC you are the only author of this file, right? Then there is no >> place for Ludovic there. > >> I think we prefer 'define-public' over exporting the package variables, >> but it is probably not a strong convention. > >> I would put "Pipe Viewer" in parentheses: >> >> "pv (Pipe Viewer) is a terminal-based tool for monitoring the pr= ogress > >> I realize that you took this description from the home page, but our >> convention is to use two spaces between sentences. > > > Updated accordingly! > > > From e93d21889bdcbed02a517f30d8401a3bb144cce4 Mon Sep 17 00:00:00 2001 > From: Claes Wallin > Date: Fri, 19 Jun 2015 20:12:09 +0200 > Subject: [PATCH] gnu: Add pv. > > * gnu/package/pv.scm (pv): New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. Thank you! It looks good to me, so I'll push it in a couple of days if no one will send additional comments/notes. --=20 Alex