Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

[Alex Kost <alezost@gmail.com>]

Claes Wallin (韋嘉誠) (2015-06-25 00:35 +0300) wrote:

> On Tue, Jun 23, 2015 at 1:43 PM, Alex Kost <alezost@gmail.com> wrote:
>
>> --8<---------------cut here---------------start------------->8---
>> gnu: Add pv.
>>
>> * gnu/package/pv.scm (pv): New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>> --8<---------------cut here---------------end--------------->8---
>>
>> And you also need to add "gnu/package/pv.scm" to "gnu-system.am".  See
>> commit 741115b for example.
>
>> IIUC you are the only author of this file, right?  Then there is no
>> place for Ludovic there.
>
>> I think we prefer 'define-public' over exporting the package variables,
>> but it is probably not a strong convention.
>
>> I would put "Pipe Viewer" in parentheses:
>>
>>         "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress
>
>> I realize that you took this description from the home page, but our
>> convention is to use two spaces between sentences.
>
>
> Updated accordingly!
>
>
> From e93d21889bdcbed02a517f30d8401a3bb144cce4 Mon Sep 17 00:00:00 2001
> From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
> Date: Fri, 19 Jun 2015 20:12:09 +0200
> Subject: [PATCH] gnu: Add pv.
>
>  * gnu/package/pv.scm (pv): New file.
>  * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Thank you!  It looks good to me, so I'll push it in a couple of days if
no one will send additional comments/notes.

-- 
Alex