From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 14/15] scripts: environment: Add --container option. Date: Fri, 10 Jul 2015 20:03:58 +0200 Message-ID: <87r3of99f5.fsf@gnu.org> References: <1436188604-2813-1-git-send-email-dthompson2@worcester.edu> <1436188604-2813-14-git-send-email-dthompson2@worcester.edu> <87zj38f326.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDceb-0008Bh-I3 for guix-devel@gnu.org; Fri, 10 Jul 2015 14:04:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDceY-0002HJ-7S for guix-devel@gnu.org; Fri, 10 Jul 2015 14:04:05 -0400 In-Reply-To: (David Thompson's message of "Thu, 9 Jul 2015 09:16:53 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: guix-devel , David Thompson "Thompson, David" skribis: > On Tue, Jul 7, 2015 at 10:35 AM, Ludovic Court=C3=A8s wrot= e: >> Since this works without root privileges, what about adding a test in >> tests/guix-environment.sh? >> >> Basically something similar to one of the existing tests, but >> additionally checking from within the container that =E2=80=98id -u=E2= =80=99 returns 0, >> that =E2=80=98$$=E2=80=99 is 2, and that files outside of $PWD are not i= n the container. > > For some reason that I haven't figured out, the existing tests do not > pass on my machine when I run: > > make check TESTS=3Dtests/guix-environment.sh > > I'm finding it difficult to debug our tests because the test runner > eats backtraces and other useful info. Could you post tests/guix-environment.log? Normally it contains both stdout and stderr, as well as all the shell lines that were executed. >> Which reminds me: In a separate commit, it Would Be Nice to document our >> minimal kernel requirements for the container functionality. Could you >> look into that? > > AFAIK the recommended minimal kernel version that folks should be > using for this stuff is 3.13, and the kernel needs to be configured > with that DEVPTS_MULTIPLE_INSTANCES flag. Where would you put this > information? The DEVPTS_MULTIPLE_INSTANCES thing should probably go in =E2=80=9CSetting = Up the Daemon.=E2=80=9D The rest could maybe go to a =E2=80=9CContainer Support=E2=80=9D section un= der =E2=80=9CInstallation=E2=80=9D that would be referenced from =E2=80=9CRequi= rements=E2=80=9D (where optional dependencies are listed)? Any better idea? Thanks, Ludo=E2=80=99.