From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: sdl-union: Wrap into a procedure and export it.
Date: Sun, 11 Oct 2015 18:50:39 +0200
Message-ID: <87r3l12vts.fsf@gnu.org>
References: <87wpv2jvgr.fsf@gmail.com> <87oag8qkp8.fsf@gnu.org>
	<CAJ=RwfYdT2kcC1JOsmVgBdrOTWtF71ORP2tWAXbZYt50M4tgvg@mail.gmail.com>
	<87twpz4sff.fsf@gnu.org> <87lhbbrtw3.fsf_-_@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53716)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZlJpf-0008GC-OH
	for guix-devel@gnu.org; Sun, 11 Oct 2015 12:50:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZlJpa-0003ff-NS
	for guix-devel@gnu.org; Sun, 11 Oct 2015 12:50:47 -0400
In-Reply-To: <87lhbbrtw3.fsf_-_@gmail.com> (Alex Kost's message of "Sat, 10
	Oct 2015 11:48:44 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

Alex Kost <alezost@gmail.com> skribis:

> From f1bd9edbbae498fb3b4726428daf523e3fd83060 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Sat, 10 Oct 2015 11:27:27 +0300
> Subject: [PATCH] gnu: sdl-union: Wrap into a procedure and export it.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=3DUTF-8
> Content-Transfer-Encoding: 8bit
>
> Suggested by Ludovic Court=C3=A8s <ludo@gnu.org>.
>
> * gnu/packages/sdl.scm (sdl-union): Make it a procedure returning
>   'sdl-union' package.
>   (guile-sdl): Use it.

I like this idea.

> +(define (sdl-union . sdl-packages)
> +  "Return 'sdl-union' package that is the union of SDL-PACKAGES.
> +If SDL-PACKAGES are not specified, all SDL libraries are used."
> +  (let* ((sdl-packages (if (null? sdl-packages)
> +                           (list sdl
> +                                 sdl-gfx
> +                                 sdl-image
> +                                 sdl-mixer
> +                                 sdl-net
> +                                 sdl-ttf)
> +                           sdl-packages))

What about writing it like this:

  (define* (sdl-union #:optional (packages (list sdl sdl-gfx =E2=80=A6)))
    =E2=80=A6)

That would be more concise and more idiomatic.

If that=E2=80=99s fine with you, OK to push with this change.

Thanks!

Ludo=E2=80=99.