From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul van der Walt Subject: Re: [PATCH 19/43] gnu: ghc-setenv: New variable. Date: Tue, 20 Oct 2015 15:38:18 +0200 Message-ID: <87r3kp4q45.fsf@denknerd.org> References: <1444911697-15515-1-git-send-email-paul@denknerd.org> <1444911697-15515-19-git-send-email-paul@denknerd.org> <20151019091438.54b21d2a@openmailbox.org> Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoX7U-0003Jo-6K for guix-devel@gnu.org; Tue, 20 Oct 2015 09:38:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoX7P-0003mA-Eh for guix-devel@gnu.org; Tue, 20 Oct 2015 09:38:28 -0400 Received: from mx01.mykolab.com ([95.128.36.1]:28458 helo=mx-out01.mykolab.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoX7P-0003lk-8d for guix-devel@gnu.org; Tue, 20 Oct 2015 09:38:23 -0400 In-reply-to: <20151019091438.54b21d2a@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Eric Bavier Cc: guix-devel@gnu.org On 2015-10-19 at 16:14, quoth Eric Bavier: >> + (home-page >> + "http://hackage.haskell.org/package/setenv") > > Please put the string on the same line as a field name. Done. >> + (synopsis >> + "A cross-platform library for setting environment variables") > > Ditto. (Note: A realize the patch on the wip-haskell-platform-7.10.2-a > is slightly different, but the same issues are there) Done. >> + (description >> + "A cross-platform library for setting environment variables.") > > In both the synopsis and the description, we don't really care about > the "cross-platform" nature of this package. Could you adjust the > wording a bit? Done.