Hello Paul

Paul van der Walt <paul@denknerd.org> writes:

> > From dc8d0477c0644e9d54ebba6af955c3d4e29270fc Mon Sep 17 00:00:00 2001
> > From: Cyrill Schenkel <cyrill.schenkel@gmail.com>
> > Date: Fri, 23 Oct 2015 13:25:11 +0200
> > Subject: [PATCH] gnu: Add xcompmgr
> > 
> > * gnu/packages/xorg.scm (xcompmgr): New variable.
> > ---
> >  gnu/packages/xorg.scm | 41 +++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> > 
> > diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> > index b39bbd4..d51cd30 100644
> > --- a/gnu/packages/xorg.scm
> > +++ b/gnu/packages/xorg.scm
> > @@ -4,6 +4,7 @@
> > [...]
> > +    (arguments
> > +     `(#:phases (modify-phases %standard-phases
> > +                  (add-before 'configure 'autogen
> > +                              (lambda _
> > +                                (setenv "NOCONFIGURE" "t")
> > +                                (zero? (system* "./autogen.sh")))))))
> > +    (native-inputs
> > [...]
>
> Mark Weaver recently told me that autogen phases should be after 'unpack
> instead of before 'configure, since the MIPS platform (and perhaps
> others) sometimes need to adjust the output of autogen.sh.

Yes, you're right. I changed it accordingly.

> ...and another thing while i'm at it, although i'm less sure about this
> one...
>
> On 2015-10-23 at 11:46, quoth Paul van der Walt:
>>> +                                (setenv "NOCONFIGURE" "t")
>
> Does that do what i think it does?  If so, why not just use something
> like the following?
>
>   (modify-phases %standard-phases
>     (delete 'configure)
>     ...)

It does what you think it does. If I did omit it, I'd need to patch the
`autogen.sh` file so that it passes the neccessary parameters to the
configure script and I'd also need to set the neccessary environment
variables. It seems to me that setting the `NOCONFIGURE` environment
variable is by far the simpler solution.

Regards,
Cyrill