From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] refresh: Support comma separated updater types.
Date: Tue, 27 Oct 2015 21:18:21 +0100
Message-ID: <87r3kgawvm.fsf@gnu.org>
References: <87d1w8crgs.fsf@gnu.org> <874mhj9v1s.fsf@gmail.com>
	<87eggik4lg.fsf@gnu.org> <87lhaoqgqa.fsf_-_@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZrAhR-0007Gw-Mf
	for guix-devel@gnu.org; Tue, 27 Oct 2015 16:18:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZrAhM-0007HL-OX
	for guix-devel@gnu.org; Tue, 27 Oct 2015 16:18:29 -0400
In-Reply-To: <87lhaoqgqa.fsf_-_@gmail.com> (Alex Kost's message of "Tue, 27
	Oct 2015 22:00:29 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

Alex Kost <alezost@gmail.com> skribis:

> From 4a5132f171dfe6bac99661e75e7c5e53c4f74116 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Tue, 27 Oct 2015 21:13:05 +0300
> Subject: [PATCH] refresh: Support comma separated updater types.
>
> * guix/scripts/refresh.scm (%options): Handle comma separated types for
>   '--type' option.
>   (guix-refresh): Adjust accordingly.
>   (show-help): Likewise.
> * doc/guix.texi (Invoking guix refresh): Document it.

[...]

> +                  (let ((names (map string->symbol (string-split arg #\,=
))))

I prefer =E2=80=98string-tokenize=E2=80=99, which is standard, even though =
it=E2=80=99s more
verbose.

> +      (lists
> +       (apply append lists))))

Rather: (concatenate lists).

OK with these changes.

Thank you for the quick patch!

Ludo=E2=80=99.