From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Timestamps in ...-autoloads.el files Date: Sat, 14 Nov 2015 16:03:29 +0100 Message-ID: <87r3jsvd1a.fsf@gnu.org> References: <87zize1mmq.fsf@gnu.org> <87si55h205.fsf@gmail.com> <87mvvde3h0.fsf@gnu.org> <87vba0mkwy.fsf@gmail.com> <87y4ew88km.fsf@gnu.org> <87y4egny5y.fsf@gmail.com> <87wptzz00j.fsf@gnu.org> <87mvug7r5z.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxcMa-00078T-Tc for guix-devel@gnu.org; Sat, 14 Nov 2015 10:03:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxcMW-0001mh-QJ for guix-devel@gnu.org; Sat, 14 Nov 2015 10:03:36 -0500 In-Reply-To: <87mvug7r5z.fsf@gmail.com> (Alex Kost's message of "Sat, 14 Nov 2015 14:32:08 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel Alex Kost skribis: > Ludovic Court=C3=A8s (2015-11-03 16:27 +0300) wrote: [...] >>> + ;; Avoid non-determinism related to generated timestamps. >>> + (setenv "SOURCE_DATE_EPOCH" "1") >>> + >>> ;; The trick is to #:allow-other-keys everywhere, so that each proce= dure in >>> ;; PHASES can pick the keyword arguments it's interested in. >>> (every (match-lambda >> >> Yes, as simple as this. > > Great, thanks! I see that you used (setenv "SOURCE_DATE_EPOCH" "0") in > 'tk-update' commit, so I also changed the value to "0". Oh, good point. I don=E2=80=99t know if it matters much (for Python it see= ms to make no difference), but I think =E2=80=9C1=E2=80=9D is the safest choice b= ecause the mtime on files in the store is set to 1, not 0. I=E2=80=99ll fix that in =E2=80=98tk-update=E2=80=99. >>>> Could you also submit it upstream, Cc=E2=80=99ing guix-devel and >>>> reproducible-builds@lists.alioth.debian.org? Hopefully that is >>>> acceptable. (I searched a bit but didn=E2=80=99t find a similar patch= by the >>>> Debian Reproducible team, but patch-tracker.debian.org is unreachable.) >>> >>> I'm afraid it's a too hard task for me, sorry. I wouldn't like to mail >>> to so many places. >> >> Or email only emacs-devel if you prefer. >> >> An experienced Emacs hacker like you shouldn=E2=80=99t have to be afraid= of that. > > After fighting with myself for all these days, I must admit I'm not > brave enough for this task yet, sorry. You=E2=80=99re not the one to be sorry. It tells more about the weaknesses= of the Emacs developer community than about yours. I=E2=80=99ll post it if you don=E2=80=99t mind. > From a99fb41a7b84dd28c1a5b3f53cf14ca3c43785e7 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Sat, 14 Nov 2015 14:04:43 +0300 > Subject: [PATCH 1/2] build-system/gnu: Set 'SOURCE_DATE_EPOCH'. > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > Suggested by Ludovic Court=C3=A8s . > > * guix/build/gnu-build-system.scm (gnu-build): Set SOURCE_DATE_EPOCH for > deterministic builds. [...] > + ;; Avoid non-determinism related to generated timestamps. > + (setenv "SOURCE_DATE_EPOCH" "0") OK with that set to 1. > From 8ee244b6470b11928aa207cf21527ca33cef31f5 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Wed, 21 Oct 2015 15:59:23 +0300 > Subject: [PATCH 2/2] gnu: emacs: Honor 'SOURCE_DATE_EPOCH'. > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > Suggested by Ludovic Court=C3=A8s . > > * gnu/packages/patches/emacs-source-date-epoch.patch: New patch. > * gnu-system.am (dist_patch_DATA): Add it. > * gnu/packages/emacs.scm (emacs)[source]: Use it. OK. Thank you! Ludo=E2=80=99.