unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add sonic.
Date: Wed, 13 Jan 2016 15:10:16 +0100	[thread overview]
Message-ID: <87r3hl4lkn.fsf@gnu.org> (raw)
In-Reply-To: <5ce5b80290833db46e031d80e43c00fec1399d7b.1452576360.git.leo@famulari.name> (Leo Famulari's message of "Tue, 12 Jan 2016 00:26:38 -0500")

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/audio.scm (sonic): New variable.

[...]

> +        #:phases (modify-phases %standard-phases
> +         (delete 'configure))))

There’s a problem here.  :-)

> +    (synopsis "Speed up or slow down speech")
> +    (description "Sonic is a simple algorithm for speeding up or slowing down

s/is a/implements a/

> +speech.  However, it's optimized for speed ups of over 2X, unlike previous
> +algorithms for changing speech rate.  The Sonic library is a very simple ANSI C
> +library that is designed to easily be integrated into streaming voice
> +applications, like TTS back ends.

I would change the last sentence to:

  Sonic is a C library designed to be easily integrated into streaming
  voice applications such as text-to-speech (TTS) back ends.

> +The primary motivation behind Sonic is to enable the blind and visually impaired
> +to improve their productivity with open source speech engines, like espeak.
                                ^‑------------------------------------------^
Replace with “with speech engines such as eSpeak.”

> +Sonic can also be used by the sighted.  For example, Sonic can improve the
> +experience of listening to an audio book on an Android phone.")

I’d remove these two sentences.

OK with these changes.

Thanks,
Ludo’.

  reply	other threads:[~2016-01-13 14:10 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12  5:26 [PATCH 0/2] Add eSpeak Leo Famulari
2016-01-12  5:26 ` [PATCH 1/2] gnu: Add sonic Leo Famulari
2016-01-13 14:10   ` Ludovic Courtès [this message]
2016-01-14  3:28     ` Leo Famulari
2016-01-12  5:26 ` [PATCH 2/2] gnu: Add espeak Leo Famulari
2016-01-13 14:17   ` Ludovic Courtès
2016-01-14  3:27     ` Leo Famulari
2016-01-15  0:38       ` Leo Famulari
2016-01-15 16:15         ` Ludovic Courtès
2016-01-14 12:02     ` Ricardo Wurmus
2016-01-14 13:32       ` Ludovic Courtès
2016-01-17 16:09         ` Ricardo Wurmus
2016-01-17 20:30           ` PulseAudio & ALSA Ludovic Courtès
2016-02-09 21:45             ` Ricardo Wurmus
2016-01-12  5:58 ` [PATCH 0/2] Add eSpeak Leo Famulari
2016-01-12  6:01   ` Leo Famulari
2016-01-12 15:48   ` Andreas Enge
2016-01-12 19:30     ` Leo Famulari
2016-01-13  0:09       ` Leo Famulari
2016-01-13 14:01 ` PulseAudio Ludovic Courtès
2016-02-09 21:26   ` PulseAudio Christopher Allan Webber
2016-02-09 21:35     ` PulseAudio Leo Famulari
2016-02-12  9:12       ` PulseAudio Ludovic Courtès
2016-02-12 10:21         ` PulseAudio Ricardo Wurmus
2016-02-12 11:13           ` PulseAudio Alex Sassmannshausen
2016-02-15  7:38             ` PulseAudio Ricardo Wurmus
2016-02-15  8:56               ` PulseAudio Alex Sassmannshausen
2016-02-09 21:43     ` PulseAudio Ricardo Wurmus
2016-02-09 23:36     ` PulseAudio Jookia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3hl4lkn.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).