* [PATCH] doc: Small fixes for typos and missing words.
@ 2016-03-30 12:37 Roel Janssen
2016-03-30 12:54 ` Ricardo Wurmus
0 siblings, 1 reply; 5+ messages in thread
From: Roel Janssen @ 2016-03-30 12:37 UTC (permalink / raw)
To: guix-devel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-doc-Small-fixes-for-typos-and-missing-words.patch --]
[-- Type: text/x-patch, Size: 2173 bytes --]
From 467315651e27c3ce3059b9fca38494879de50e5e Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Wed, 30 Mar 2016 14:27:52 +0200
Subject: [PATCH] doc: Small fixes for typos and missing words.
* doc/guix.texi (The Store Monad): Add a dot at the end of a sentence.
(The Store Monad): Add "are" to make a complete sentence.
(G-Expressions): Fix typo.
---
doc/guix.texi | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 1a7f188..2407a41 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -3245,7 +3291,7 @@ provides a framework for working with @dfn{monads}, and a particularly
useful monad for our uses, the @dfn{store monad}. Monads are a
construct that allows two things: associating ``context'' with values
(in our case, the context is the store), and building sequences of
-computations (here computations include accesses to the store.) Values
+computations (here computations include accesses to the store.). Values
in a monad---values that carry this additional context---are called
@dfn{monadic values}; procedures that return such values are called
@dfn{monadic procedures}.
@@ -3274,7 +3320,7 @@ as a monadic function:
#$output))))
@end example
-There several things to note in the second version: the @code{store}
+There are several things to note in the second version: the @code{store}
parameter is now implicit and is ``threaded'' in the calls to the
@code{package->derivation} and @code{gexp->derivation} monadic
procedures, and the monadic value returned by @code{package->derivation}
@@ -3541,7 +3587,7 @@ S-expressions adapted to build expressions. G-expressions, or
@code{ungexp}, and @code{ungexp-splicing} (or simply: @code{#~},
@code{#$}, and @code{#$@@}), which are comparable to
@code{quasiquote}, @code{unquote}, and @code{unquote-splicing},
-respectivel (@pxref{Expression Syntax, @code{quasiquote},, guile,
+respectively (@pxref{Expression Syntax, @code{quasiquote},, guile,
GNU Guile Reference Manual}). However, there are major differences:
@itemize
--
2.5.5
[-- Attachment #2: Type: text/plain, Size: 282 bytes --]
Dear Guix,
I noticed some typos and/or missing words when reading parts of the
manual. Instead of leaving it be, I attached a patch to fix them.
I don't know how my commit message should look like in this case, so
please let me know when it is wrong.
Kind regards,
Roel Janssen
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] doc: Small fixes for typos and missing words.
2016-03-30 12:37 [PATCH] doc: Small fixes for typos and missing words Roel Janssen
@ 2016-03-30 12:54 ` Ricardo Wurmus
2016-03-30 13:10 ` Roel Janssen
2016-03-30 22:10 ` Alex Kost
0 siblings, 2 replies; 5+ messages in thread
From: Ricardo Wurmus @ 2016-03-30 12:54 UTC (permalink / raw)
To: Roel Janssen; +Cc: guix-devel
Roel Janssen <roel@gnu.org> writes:
> Dear Guix,
>
> I noticed some typos and/or missing words when reading parts of the
> manual. Instead of leaving it be, I attached a patch to fix them.
>
> I don't know how my commit message should look like in this case, so
> please let me know when it is wrong.
I think the first fix should be this:
-computations (here computations include accesses to the store.) Values
+computations (here computations include accesses to the store). Values
rather than having a period both in and outside the parentheses.
~~ Ricardo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] doc: Small fixes for typos and missing words.
2016-03-30 12:54 ` Ricardo Wurmus
@ 2016-03-30 13:10 ` Roel Janssen
2016-03-30 21:24 ` Ludovic Courtès
2016-03-30 22:10 ` Alex Kost
1 sibling, 1 reply; 5+ messages in thread
From: Roel Janssen @ 2016-03-30 13:10 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-doc-Small-fixes-for-typos-and-missing-words.patch --]
[-- Type: text/x-patch, Size: 2172 bytes --]
From 467315651e27c3ce3059b9fca38494879de50e5e Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Wed, 30 Mar 2016 14:27:52 +0200
Subject: [PATCH] doc: Small fixes for typos and missing words.
* doc/guix.texi (The Store Monad): Add a dot at the end of a sentence.
(The Store Monad): Add "are" to make a complete sentence.
(G-Expressions): Fix typo.
---
doc/guix.texi | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 1a7f188..2407a41 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -3245,7 +3291,7 @@ provides a framework for working with @dfn{monads}, and a particularly
useful monad for our uses, the @dfn{store monad}. Monads are a
construct that allows two things: associating ``context'' with values
(in our case, the context is the store), and building sequences of
-computations (here computations include accesses to the store.) Values
+computations (here computations include accesses to the store). Values
in a monad---values that carry this additional context---are called
@dfn{monadic values}; procedures that return such values are called
@dfn{monadic procedures}.
@@ -3274,7 +3320,7 @@ as a monadic function:
#$output))))
@end example
-There several things to note in the second version: the @code{store}
+There are several things to note in the second version: the @code{store}
parameter is now implicit and is ``threaded'' in the calls to the
@code{package->derivation} and @code{gexp->derivation} monadic
procedures, and the monadic value returned by @code{package->derivation}
@@ -3541,7 +3587,7 @@ S-expressions adapted to build expressions. G-expressions, or
@code{ungexp}, and @code{ungexp-splicing} (or simply: @code{#~},
@code{#$}, and @code{#$@@}), which are comparable to
@code{quasiquote}, @code{unquote}, and @code{unquote-splicing},
-respectivel (@pxref{Expression Syntax, @code{quasiquote},, guile,
+respectively (@pxref{Expression Syntax, @code{quasiquote},, guile,
GNU Guile Reference Manual}). However, there are major differences:
@itemize
--
2.5.5
[-- Attachment #2: Type: text/plain, Size: 680 bytes --]
Ricardo Wurmus writes:
> Roel Janssen <roel@gnu.org> writes:
>
>> Dear Guix,
>>
>> I noticed some typos and/or missing words when reading parts of the
>> manual. Instead of leaving it be, I attached a patch to fix them.
>>
>> I don't know how my commit message should look like in this case, so
>> please let me know when it is wrong.
>
> I think the first fix should be this:
>
> -computations (here computations include accesses to the store.) Values
> +computations (here computations include accesses to the store). Values
>
> rather than having a period both in and outside the parentheses.
Yes, that is nicer.
Attached the modified patch.
Kind regards,
Roel Janssen
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] doc: Small fixes for typos and missing words.
2016-03-30 13:10 ` Roel Janssen
@ 2016-03-30 21:24 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2016-03-30 21:24 UTC (permalink / raw)
To: Roel Janssen; +Cc: guix-devel
Roel Janssen <roel@gnu.org> skribis:
> From 467315651e27c3ce3059b9fca38494879de50e5e Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Wed, 30 Mar 2016 14:27:52 +0200
> Subject: [PATCH] doc: Small fixes for typos and missing words.
>
> * doc/guix.texi (The Store Monad): Add a dot at the end of a sentence.
> (The Store Monad): Add "are" to make a complete sentence.
> (G-Expressions): Fix typo.
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] doc: Small fixes for typos and missing words.
2016-03-30 12:54 ` Ricardo Wurmus
2016-03-30 13:10 ` Roel Janssen
@ 2016-03-30 22:10 ` Alex Kost
1 sibling, 0 replies; 5+ messages in thread
From: Alex Kost @ 2016-03-30 22:10 UTC (permalink / raw)
To: guix-devel
Ricardo Wurmus (2016-03-30 15:54 +0300) wrote:
> Roel Janssen <roel@gnu.org> writes:
>
>> Dear Guix,
>>
>> I noticed some typos and/or missing words when reading parts of the
>> manual. Instead of leaving it be, I attached a patch to fix them.
>>
>> I don't know how my commit message should look like in this case, so
>> please let me know when it is wrong.
>
> I think the first fix should be this:
>
> -computations (here computations include accesses to the store.) Values
> +computations (here computations include accesses to the store). Values
>
> rather than having a period both in and outside the parentheses.
I agree, this looks natural to me, but I heard (from Ludo) that there is
some "typographic school" (or how is it called), that says "(foo.)" is
the correct thing.
That line originally appeared in commit b860f3824¹, and I'm afraid it was
intended to be written that way.
¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=b860f382447a360ea2ce8a89d3357279cc652c3a
--
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-30 22:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-30 12:37 [PATCH] doc: Small fixes for typos and missing words Roel Janssen
2016-03-30 12:54 ` Ricardo Wurmus
2016-03-30 13:10 ` Roel Janssen
2016-03-30 21:24 ` Ludovic Courtès
2016-03-30 22:10 ` Alex Kost
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).