From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 4/9] services: syslog: Use syslog-configuration.
Date: Fri, 02 Sep 2016 14:31:25 +0200
Message-ID: <87r392mqjm.fsf@gnu.org>
References: <20160901155711.7388-1-david@craven.ch>
	<20160901155711.7388-4-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50035)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bfnd7-0000oF-T8
	for guix-devel@gnu.org; Fri, 02 Sep 2016 08:31:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bfnd2-0004YH-8b
	for guix-devel@gnu.org; Fri, 02 Sep 2016 08:31:32 -0400
In-Reply-To: <20160901155711.7388-4-david@craven.ch> (David Craven's message
	of "Thu, 1 Sep 2016 17:57:06 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/services/base.scm (<syslog-configuration>): New variable.
> (syslog-service-type): Use <syslog-configuration>.
> (syslog-service): Use <syslog-configuration>.

Please mention the gnu/tests/base.scm changes here.

> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -73,15 +73,15 @@
>=20=20
>              %nscd-default-caches
>              %nscd-default-configuration
> -
>              nscd-configuration
>              nscd-configuration?
> -
>              nscd-cache
>              nscd-cache?
> -

Please keep the spacing.

> +(define-record-type* <syslog-configuration>
> +  syslog-configuration  make-syslog-configuration
> +  syslog-configuration?
> +  (syslogd              syslog-configuration-syslogd
> +                        (default #~(string-append #$inetutils "/libexec/=
syslogd")))
> +  (config-file          syslog-configuration-config-file
> +                        (default %default-syslog.conf)))

Good idea!

> -(define* (syslog-service #:key (config-file %default-syslog.conf))
> +(define* (syslog-service #:optional (config (syslog-configuration)))
>    "Return a service that runs @command{syslogd}.  If configuration file
>  name @var{config-file} is not specified, use some reasonable default
>  settings.
>=20=20
>  @xref{syslogd invocation,,, inetutils, GNU Inetutils}, for more
>  information on the configuration file syntax."
> -  (service syslog-service-type config-file))
> +  (service syslog-service-type config))

Could you update the docstring and guix.texi, and add an @deftp for
=E2=80=98syslog-configuration=E2=80=99 in guix.texi?

TIA!

Ludo=E2=80=99.