unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add python-cachecontrol.
Date: Sun, 11 Sep 2016 02:11:08 +0100	[thread overview]
Message-ID: <87r38rckb7.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <40a18799-2091-6ed2-bd96-f5d37c20dcfb@uq.edu.au>

Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

> Hi Marius, thanks for the patch.
>
> I added a 'python2-variant' line and pushed as 'b30565b'.

*facepalm* thanks. Here I was wondering why my next patches didn't build
for python2. You may want to do the same for "python-freezegun" above.

Btw, it seems you missed a couple of parenthesis in the commit:

-    (properties `((python2-variant . ,(delay python2-cachecontrol)))
+    (properties `((python2-variant . ,(delay python2-cachecontrol))))))

> The thing is, the list has already seen this package before, in this 
> thread where I tried packaging scikit-bio (I suspect you are trying to 
> do the same):
> https://lists.gnu.org/archive/html/guix-devel/2016-04/msg01012.html

I am indeed sending these to prepare for scikit-bio. Natsort coming up.
There have been a few dependency updates as well, since that thread.

I'll take a look at your branch to see if it contains anything I might
have missed. The remaining dependencies are pretty much ready to go.

Cheers!
Marius

      reply	other threads:[~2016-09-11  1:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-10 10:24 [PATCH] gnu: Add python-cachecontrol Marius Bakke
2016-09-11  0:01 ` Ben Woodcroft
2016-09-11  1:11   ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r38rckb7.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).