From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Clean all .go in clean-go
Date: Tue, 20 Sep 2016 14:20:12 +0900
Message-ID: <87r38fp2pf.fsf@gnu.org>
References: <20160831232034.13748-1-ericbavier@openmailbox.org>
	<8760qgjugu.fsf@gnu.org> <874m5zokwp.fsf@gnu.org>
	<20160901203035.1ea32dee@openmailbox.org> <8737limq18.fsf@gnu.org>
	<20160916001540.617d9a54@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37938)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bmLKO-0007lq-TS
	for guix-devel@gnu.org; Tue, 20 Sep 2016 09:43:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bmLKL-0003RT-Ot
	for guix-devel@gnu.org; Tue, 20 Sep 2016 09:43:16 -0400
In-Reply-To: <20160916001540.617d9a54@openmailbox.org> (Eric Bavier's message
	of "Fri, 16 Sep 2016 00:15:40 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org

Hi,

Eric Bavier <ericbavier@openmailbox.org> skribis:

> So, with the attached patch, I get the following output after `make
> clean-go`:
>
> warning: stray .go files: ./guix/scripts/import/cpan.go ./gnu/services/dm=
d.go
> ./gnu/system/linux.go ./gnu/packages/yasm.go ./gnu/packages/cursynth.go=20
> ./gnu/packages/lightning.go ./gnu/packages/doxygen.go ./gnu/packages/tre.=
go=20
> ./gnu/packages/asciidoc.go ./gnu/packages/texlive.go ./gnu/packages/i3.go=
=20
> ./gnu/packages/fish.go ./gnu/packages/slim.go ./gnu/packages/tcsh.go=20
> ./gnu/packages/zsh.go ./gnu/packages/lsh.go ./gnu/packages/rc.go=20
> ./gnu/packages/openssl.go ./gnu/packages/aria2.go ./gnu/packages/gdbm.go=
=20
> ./gnu/packages/gnutls.go ./gnu/packages/grue-hunter.go ./gnu/packages/aar=
ddict.go

Looks good, surely an improvement!

> Another issue that I thought of that's posed by these stray .go files,
> which isn't only a problem when acting as a wizard: introducing a new
> module import when adding a package, only to have that module
> moved/renamed before pushing your change.  I suppose it is a corner
> case, but it did happen to me recently, in 2e3f18511, which =E5=AE=8B=E6=
=96=87=E6=AD=A6
> kindly fixed in 19b2ea1b6. The problem was that between the time I
> originally packaged tomb and the time I pushed the commit,
> gnu/packages/zsh.scm was consolidated into gnu/packages/shells.scm.  I
> had done a `make clean-go && make` before pushing, as I always do, but
> since clean-go didn't remove gnu/packages/zsh.go the subsequent `make`
> didn't complain of a missing module.

Indeed, that=E2=80=99s happened to me before.

> From ffe1710d5a91cd9906f2419d21944b1375b1b842 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Thu, 15 Sep 2016 23:31:41 -0500
> Subject: [PATCH] build: clean-go: warn about stray .go files.
>
> * Makefile.am (clean-go): Warn of .go files remaining in builddir.

LGTM, thank you!

Ludo=E2=80=99.