From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add tipp10 touch typing tutor. Date: Thu, 05 Jan 2017 11:55:21 +0100 Message-ID: <87r34hu67a.fsf@gnu.org> References: <1482074241-30845-1-git-send-email-h.goebel@crazy-compilers.com> <87poknzjhv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cP5hf-0002VK-IC for guix-devel@gnu.org; Thu, 05 Jan 2017 05:55:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cP5hc-0002ZR-Hf for guix-devel@gnu.org; Thu, 05 Jan 2017 05:55:27 -0500 In-Reply-To: (Hartmut Goebel's message of "Sat, 31 Dec 2016 15:36:05 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel Cc: guix-devel@gnu.org Hello, Hartmut Goebel skribis: > Am 19.12.2016 um 22:39 schrieb Ludovic Court=C3=A8s: >> >>> + (uri (string-append "mirror://debian/pool/main/" >>> + "t/tipp10/tipp10_2.1.0.orig.tar.gz")) >> Is there really no upstream for this program? tipp10.com seems to be >> live, no? > > There is, but guix is not able to handle the download URL, which is > or > .This page > uses " content=3D"1;url=3D/en/download/getfile/3/1483193955/" />". I asked the > author for a different URL, but he did not answer. OK. In this case, I think the future you (or anyone else) would appreciate a comment that says just that. ;-) >> >>> + (patches (search-patches "tipp10-FixCompiling.patch" >>> + "tipp10-RemoveLicenseCode.patch= ")))) >> Please use lowercase and hyphens for file names. :-) > > Anything else unimportant I can waste my time on? These are the > file-names of the patches at debian. I see absolutely no benefit in > changing them. We have conventions, comments like the one I did are certainly boring, but I think it=E2=80=99s beneficial to everyone when the code is consistent. >> >>> + (description " TIPP10 is a free touch typing tutor for Windows, Ma= c OS and >> ^ >> Extra space. >> >> Please don=E2=80=99t mention supported operating systems; what matters i= s that >> it works on GNU. > > IMO this is interesting for users and for spreading free software. If > one reads this i might think: "O, coll, I can recommend this to some > friend still using Windooze and ma convince her about free software." I understand, but the description is meant for Guix users, so it=E2=80=99s a different purpose. >>> +Linux. The ingenious thing about the software is its intelligence fea= ture. >> =E2=80=9CIntelligence feature=E2=80=9D sounds vague; could it be rephras= ed in more >> precise terms? >> >>> +Note: To change the language settings choose Datei (File) =E2=86=92 >>> +Grundeinstellungen (Generell Settings) =E2=86=92 Sprache (Language) an= d change from >>> +Deutsch to English. The you have restart the program to have the chang= e take >>> +effect.") >> This information doesn=E2=80=99t belong here. >> >> Does Debian have patches to make this program honor the current locale? >> That would be the best option. > > No, there are not patches, this is why I put this information there. If > ou dislike, please recommend a better place. No suggestions, leave it here if that=E2=80=99s the best we can do. >>> + (license license:gpl2))) >> Version 2 only? > > This is what https://www.tipp10.com/en/download/ says. My comment was more about whether you checked the source code headers, which are authoritative. They do not have the =E2=80=9Cor any later versio= n=E2=80=9D wording, so that=E2=80=99s =E2=80=98gpl2=E2=80=99 indeed. >>> +-Exec=3Dtipp10 >>> ++Exec=3D/usr/bin/tipp10 >> This doesn=E2=80=99t look useful. > > Yes, but this is part of the original Debian patch. I'd prefer to keep > this patch unchanged to make it easier to follow any changes or fixes > Debian incorporates. Since guix is fixing this path anyway, there is no > use in maintaining a own set of patches. OK. > To be frank, some of your comment on this patch are nitpicking at its > best. I have the impression that you did not trust me to have spend only > a little thought on what I'm doing. And you are demanding things (patch > filenames, change to upstream patches) which have no or negligible > benefit =E2=80=93 even if seen in the long run. This *very* discouraging! (As a side note, these are not =E2=80=9Cupstream patches=E2=80=9D.) I=E2=80=99m sorry to read that. The way I see it is that we all do our bes= t to improve the system. Thanks, Ludo=E2=80=99.