Re: [PATCH 2/3] gnu: Add fluid.

[ng0 <ng0@libertad.pw>]

Ludovic Courtès <ludo@gnu.org> writes:

> Hi!
>
> ng0 <ng0@libertad.pw> skribis:
>
>> * gnu/packages/qt.scm (fluid): New variable.
>
> I think it’s best to put it in kde.scm or some other place; it feels
> wrong to import (gnu packages kde-frameworks) in (gnu packages qt).

Okay, I will move it to kde-frameworks. It's somewhat Qt related
as far (and as little) as I understand Material Design, but it
doesn't matter to me where the package is.

>> +(define-public fluid
>> +  (package
>> +    (name "fluid")
>> +    (version "0.9.0")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://github.com/lirios/fluid/releases/download/"
>> +                           "v" version "/" name "-" version ".tar.xz"))
>> +       (file-name (string-append name "-" version ".tar.xz"))
>> +       (sha256
>> +        (base32
>> +         "0m6mijlnizgvmh0z2wcrmkfl5cdrylxz3d7bqii8dasmm0q8f68y"))))
>> +    (build-system cmake-build-system)
>> +    (arguments
>> +     `(#:tests? #f ; XXX: The tests do not find the fluid module.
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'build 'setenv
>> +                     (lambda _
>> +                       (setenv "QT_QPA_PLATFORM" "offscreen"))))))
>
> Please add as a comment why this is needed, and add this phase before
> ‘check’ for clarity.  Also add #t as the return value.

Okay.

> I removed the #:tests? #f as Danny suggested, but the tests are failing
> in a way that suggests there’s something wrong:
>
> --8<---------------cut here---------------start------------->8---
> Test project /tmp/guix-build-fluid-0.9.0.drv-0/build
>     Start 1: tst_controls
> 1/3 Test #1: tst_controls .....................***Failed    0.05 sec
> file:///tmp/guix-build-fluid-0.9.0.drv-0/fluid-0.9.0/tests/auto/controls/tst_icon.qml:17:1: module "Fluid.Controls" is not installed 
>      import Fluid.Controls 1.0 
>      ^
> ********* Start testing of tst_controls *********
> Config: Using QtTest library 5.7.1, Qt 5.7.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.4)
> QWARN  : tst_controls::tst_icon::compile() 
>   /tmp/guix-build-fluid-0.9.0.drv-0/fluid-0.9.0/tests/auto/controls/tst_icon.qml produced 1 error(s):
>     /tmp/guix-build-fluid-0.9.0.drv-0/fluid-0.9.0/tests/auto/controls/tst_icon.qml:17,1: module "Fluid.Controls" is not installed
>   Working directory: /tmp/guix-build-fluid-0.9.0.drv-0/build/tests/auto/controls
>   View: QQuickView, import paths:
>     '/tmp/guix-build-fluid-0.9.0.drv-0/build/tests/auto/controls'
>     'qrc:/qt-project.org/imports'
>     '/gnu/store/0v50sh1lgkwkhxxq1v37ayxr15vayn6k-qtdeclarative-5.7.1/qml'
>     '/gnu/store/31mn2qgx5gh3zg3pk4w0j2a89jrkqnyv-qtquickcontrols2-5.7.1/qml'
>   Plugin paths:
>     '.'
>
> FAIL!  : tst_controls::tst_icon::compile() module "Fluid.Controls" is not installed
> --8<---------------cut here---------------end--------------->8---
>
> Could you check what’s going on?

I know, and I have no idea. I'd rather let someone with more Qt
experience work on this, but I will give it a try.

> Thanks you!
>
> Ludo’.
>

Thanks for reviewing
-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/