From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 5/6] gnu: Add ceph. Date: Wed, 18 Jan 2017 00:11:18 +0100 Message-ID: <87r3419t9l.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170115203338.19769-1-mbakke@fastmail.com> <20170115203338.19769-6-mbakke@fastmail.com> <87a8apb8x1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTcuV-0004Ux-QN for guix-devel@gnu.org; Tue, 17 Jan 2017 18:11:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTcuS-0007t0-K1 for guix-devel@gnu.org; Tue, 17 Jan 2017 18:11:27 -0500 In-Reply-To: <87a8apb8x1.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: >> + (substitute* "src/Makefile.in" >> + ;; By default, the PYTHONPATH is set to "src/pybind". >> + ;; Make sure our libraries are found too. >> + (("export PYTHONPATH=3D") (string-append "export PYTHONP= ATH=3D" >> + (getenv "PYTHONPA= TH") >> + ":")) > > I=E2=80=99d move (string-append =E2=80=A6) on the next line (for the foll= owing > substitutions as well.) I tried that, but actually found this easier to read. :-) Will double-check. >> + ;; Ceph is licensed under LGPL2.1, but includes a number of compone= nts >> + ;; covered by other licenses. Consult COPYING for full information. >> + (license (list license:lgpl2.1 >> + license:cc-by-sa3.0 ; documentation >> + license:bsd-2 ; xxHash >> + license:bsd-3 >> + license:gpl3 >> + license:gpl2 >> + license:public-domain >> + license:boost1.0 >> + license:expat)))) > > No =E2=80=9Cor any later version=E2=80=9D clause for the GNU licenses her= e? Oops, yes, there are some gpl2+ files at least. But Ceph itself is LGPL2.1 only AFAICT; the COPYING file has a debian-style copyright format and adds "or later" on some components but not on '*'. No copyright headers in the source files I've checked. Unfortunately COPYING does not cover the bundled components, so I still have some digging to do. > Then apart from the wrapping that you mentioned in the cover letter and > other issues, that looks good. Great work! Thanks! I'm sure there is a lot of work remaining to make *everything* work (e.g. 'ceph-deploy'), but will make sure it's possible to provision a cluster the "old school" way at least :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlh+pJcACgkQoqBt8qM6 VPqYBQf/Qbcp7DNIqxPwryLlWIVgOHs0Tms/FnfBYI0h5BxK861SYMIGaukmzm8N xGOWrndB6aYtmfpxCx4fDBIqkAmFkB7TLzJAlvTXmQTC8kDyL5+q9Dck7H1xaiIY UYUJXcP7P3BTQ7qcf/45AyLeyiD9qlFy+NK1NQ2kBd7i1gk87c67WUOpBO3B1hJO 25NUBvuW5CNobTHu3I3MonmY9btxy73zU39nYgq6h8C/0CuQT4yeBu5pXidml704 8V/gYRGHNI7/P1f+OLigUmRRTzv3TeFiAozO68AQWg9/u3rBWu4TheZxwMO9JLIj DLHrxH8IwyCU+skIN0SQQe5yJO6GDA== =y4If -----END PGP SIGNATURE----- --=-=-=--